-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Assume Role with Web Identity and honour skip_metadata_api_check = false
#24441
Conversation
Relevant docs for the EC2 Metadata service change: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% go test -v ./internal/provider
=== RUN TestExpandEndpoints
--- PASS: TestExpandEndpoints (0.00s)
=== RUN TestEndpointMultipleKeys
--- PASS: TestEndpointMultipleKeys (0.00s)
=== RUN TestEndpointEnvVarPrecedence
2022/04/28 08:00:57 [WARN] The environment variable "AWS_STS_ENDPOINT" is deprecated. Use "TF_AWS_STS_ENDPOINT" instead.
--- PASS: TestEndpointEnvVarPrecedence (0.00s)
=== RUN TestValidAssumeRoleDuration
--- PASS: TestValidAssumeRoleDuration (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/provider 0.872s
A similar change should be made in https://github.com/hashicorp/terraform-provider-awscc which currently fails to build with aws-sdk-go-base v2.0.0-beta.16:
|
This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adds support for Assume Role with Web Identity.
Allows the provider config
skip_metadata_api_check
to override theAWS_EC2_METADATA_DISABLED
environment variable.Closes #24370.
Closes #22907.
Relates hashicorp/aws-sdk-go-base#178.
Relates hashicorp/aws-sdk-go-base#240.
Output from acceptance testing:
N/A