-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds sync_compliance attribute to ssm_association resource, fixes #22945 #23515
adds sync_compliance attribute to ssm_association resource, fixes #22945 #23515
Conversation
hey @gdavison I have fixed the issue with the linting if you can re-trigger the ci 🙏 |
9efc3aa
to
40222c2
Compare
40222c2
to
1fe2e3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
$ make testacc TESTARGS='-run=TestAccSSMAssociation_' PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run=TestAccSSMAssociation_ -timeout 180m
--- PASS: TestAccSSMAssociation_withDocumentVersion (55.84s)
--- PASS: TestAccSSMAssociation_withOutputLocation_waitForSuccessTimeout (58.95s)
--- PASS: TestAccSSMAssociation_syncCompliance (79.85s)
--- PASS: TestAccSSMAssociation_rateControl (89.34s)
--- PASS: TestAccSSMAssociation_withScheduleExpression (89.64s)
--- PASS: TestAccSSMAssociation_withComplianceSeverity (90.10s)
--- PASS: TestAccSSMAssociation_applyOnlyAtCronInterval (90.28s)
--- PASS: TestAccSSMAssociation_withAssociationName (90.57s)
--- PASS: TestAccSSMAssociation_withAssociationNameAndScheduleExpression (91.33s)
--- PASS: TestAccSSMAssociation_withParameters (92.00s)
--- PASS: TestAccSSMAssociation_withAutomationTargetParamName (100.21s)
--- PASS: TestAccSSMAssociation_withTargets (112.70s)
--- PASS: TestAccSSMAssociation_withOutputLocation (117.39s)
--- PASS: TestAccSSMAssociation_withOutputLocation_s3Region (119.59s)
--- PASS: TestAccSSMAssociation_disappears (129.15s)
--- PASS: TestAccSSMAssociation_disappears_document (130.14s)
--- PASS: TestAccSSMAssociation_basic (266.97s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 270.656s
@iwarapter thank you for the contribution! 🎉 |
This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #22945
Output from acceptance testing:
The change requires usage of
ignore_changes
so should probably need some additions to the docs?