'make gen' fails

[ewbankkit]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

$ make gen
rm -f aws/internal/keyvaluetags/*_gen.go
go generate ./...
# github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags
./iam_tags.go:34:37: updatedTags.IgnoreAws().IamTags undefined (type KeyValueTags has no field or method IamTags)
./iam_tags.go:69:37: updatedTags.IgnoreAws().IamTags undefined (type KeyValueTags has no field or method IamTags)
aws/internal/keyvaluetags/key_value_tags.go:1: running "go": exit status 2
GNUmakefile:13: recipe for target 'gen' failed
make: *** [gen] Error 1

This is caused by me adding iam_tags.go, which contains hand written custom tag functionality, in #11598. As this code references generated methods it fails to compile during the generate phase.

[ewbankkit]

We need to move the custom functionality to its own package -
github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags/custom?

[ghost]

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!