Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon EBS Fast Snapshot Restore #10972

Closed
ewbankkit opened this issue Nov 21, 2019 · 10 comments · Fixed by #35211
Closed

Amazon EBS Fast Snapshot Restore #10972

ewbankkit opened this issue Nov 21, 2019 · 10 comments · Fixed by #35211
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

You can now enable Fast Snapshot Restore (FSR) on Amazon Elastic Block Store (EBS) snapshots, ensuring that EBS volumes restored from FSR-enabled snapshots instantly receive full provisioned performance.

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_ebs_snapshot" "example" {
  fast_snapshot_restore {
  }
}

References

Announcement.
Blog post.
User guide.

Requires AWS SDK v1.25.39:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 21, 2019
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Nov 21, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 21, 2019
@blckct
Copy link
Contributor

blckct commented Nov 22, 2019

That's a cool feature!
It seems the configuration should be a simple true/false though? Maybe with an option to skip waiting for the snapshot to be optimised?

@ewbankkit
Copy link
Contributor Author

@blckct A brief look at the API suggested to me that you would have to specify the AZs for the FSR.

@blckct
Copy link
Contributor

blckct commented Nov 22, 2019

@ewbankkit Oh, you're right.

@jleeh
Copy link

jleeh commented Nov 22, 2019

Would it make sense to have a seperate resource for this as well as a block within the snapshot resource?

Line of thinking is that FSR can be enabled and disabled independently to the snapshot creation, so users may want to enable/disable FSR in different pipelines to the snapshot creation. Especially considering the cost of FSR.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 29, 2020
@Surajgupta9160
Copy link

Do we have any update on this feature?

@ron-spree
Copy link

Almost three years later, perhaps this has been implemented elsewhere, or is it still a wishlist/pending feature?

@breathingdust breathingdust added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2023
@nikoul
Copy link

nikoul commented Dec 6, 2023

Hello @breathingdust, happy to see this got prioritized. Any estimation on when it would be available? Happy to contribute if needed.
Thanks!

@jar-b
Copy link
Member

jar-b commented Dec 19, 2023

Related APIs

Proposed Design

As the CreateSnapshot API does not provide a mechanism to enable/disable fast snapshot restoration as part of the initial creation, I'd propose implementing this as a separate, standalone resource. The EnableFastSnapshotRestores API can accept multiple snapshot identifiers in a single request, however, implementing this as a singular resource (single ID versus an array of IDs) aligns with the preferred design principles for the AWS provider. This design also prevents partial failure scenarios where some items complete successfully and others fail, leaving a complex remote state to reconcile on the following plan/apply.

resource "aws_ebs_fast_snapshot_restore" "example" {
  availability_zone  = "us-east-2a"
  source_snapshot_id = aws_ebs_snapshot.example.id
}

@jar-b jar-b self-assigned this Dec 19, 2023
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 10, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants