Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add run applied status #353

Merged
merged 7 commits into from
Mar 5, 2024
Merged

🚀 Add run applied status #353

merged 7 commits into from
Mar 5, 2024

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Feb 29, 2024

Description

Move the Run status reconciliation to a separate step and update its logic. This allows us to reduce the number of API calls that the Workspace controller makes when there is no active Run. In this PR, it will request the current Run status only if there is a new/incomplete Run that has not yet been synchronized. If the current Run is incomplete, the Workspace will reconcile the workspace more frequently, allowing synchronization of outputs to occur faster.

Tests

Usage Example

N/A.

References

N/A.

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@arybolovlev arybolovlev marked this pull request as ready for review February 29, 2024 14:04
@arybolovlev arybolovlev requested a review from a team as a code owner February 29, 2024 14:04
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff.

I'm usually a fan of more explicit error messages, but more importantly see my question about initialising w.instance.Status.Run.

Otherwise looks great!

Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, very nice! 🚀

@arybolovlev arybolovlev merged commit 236eaca into main Mar 5, 2024
7 checks passed
@arybolovlev arybolovlev deleted the add-run-applied-status branch March 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants