-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Add run applied status #353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff.
I'm usually a fan of more explicit error messages, but more importantly see my question about initialising w.instance.Status.Run
.
Otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, very nice! 🚀
Description
Move the Run status reconciliation to a separate step and update its logic. This allows us to reduce the number of API calls that the
Workspace
controller makes when there is no active Run. In this PR, it will request the current Run status only if there is a new/incomplete Run that has not yet been synchronized. If the current Run is incomplete, theWorkspace
will reconcile the workspace more frequently, allowing synchronization of outputs to occur faster.Tests
Usage Example
N/A.
References
N/A.
Community Note