Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualbox OVF/OVA mutates URL #7288

Closed
cirrith opened this issue Feb 7, 2019 · 5 comments · Fixed by #6999
Closed

Virtualbox OVF/OVA mutates URL #7288

cirrith opened this issue Feb 7, 2019 · 5 comments · Fixed by #6999
Labels

Comments

@cirrith
Copy link

cirrith commented Feb 7, 2019

Builder: Virtualbox ovf
Using source_path to specify username and password to access password protected ova online mutates characters so different password is displayed.

{
    "builders": [{
        "type": "virtualbox-ovf",
        "source_path": "https://username:[email protected]/image.ova",
        "ssh_username": "root"
    }]
}

Results in the following:
Downloading: https://username:pass%[email protected]/image.ova

Looks like it is occurring with the following characters:
!@*()

Each character maps to a different %XX value
I only tried the top row of qwerty keyboard

Packer Version: 1.3.3
Host platform: Ubuntu 18.04, amd64

@rickard-von-essen
Copy link
Collaborator

The URL is url encoded, that is how it should be. To my knowledge source_path doesn't support Basic Auth.

@azr azr mentioned this issue Feb 7, 2019
9 tasks
@cirrith
Copy link
Author

cirrith commented Feb 7, 2019

You can do authorization in the url but it seems like it isn't 100% encoding it one way or another cause ':' should have resolved so %3A
https://en.wikipedia.org/wiki/Percent-encoding

@SwampDragons
Copy link
Contributor

We have a PR in progress right now that should resolve this, so I'm not going to work on it independently at the moment -- to work around for now, you can download the file to a local cache and just give Packer the filepath.

@cirrith
Copy link
Author

cirrith commented Feb 9, 2019

Of course, looks like a big change. I was hoping not to put a wrapper script around packer. I will double check after the PR is done. Thank you, amazing tool!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants