Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Checks for Group Services #6162

Closed
schmichael opened this issue Aug 20, 2019 · 1 comment · Fixed by #6197
Closed

Register Checks for Group Services #6162

schmichael opened this issue Aug 20, 2019 · 1 comment · Fixed by #6197
Assignees
Labels
Milestone

Comments

@schmichael
Copy link
Member

Followup to #6042

PR #6157 does not handle registering checks against the new ServiceCheck.Task field added in #6131.

{Register,Update,Remove}Group methods must defer check registration to TaskRunner so they can be associated with the correct Task. The associated task is required for script checks and check_restart to work.

May want to look into the misleading script check error message from #6110 at the same time.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants