Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: adds option to enable verbose logging during sso #24892

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

mismithhisler
Copy link
Member

@mismithhisler mismithhisler commented Jan 17, 2025

Description

Adds the ability to enable a verbose logger when configuring an auth-method. This logger will output token claims and information related to how claims are mapped to Nomad identities, and how those identities map to Nomad binding-rules and role/policies.

Testing & Reproduction steps

Create an auth-method and enable the VerboseLogging option. Then start the process of configuring SSO and see the logs.

Links

Fixes GH #16360

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@mismithhisler
Copy link
Member Author

Please feel free to be critical of the log messages I've added, and if you think they are/aren't helpful.

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for doing this.

I've added some comments inline which I think would be good to figure out before merging.

.changelog/24892.txt Outdated Show resolved Hide resolved
nomad/acl_endpoint.go Show resolved Hide resolved
nomad/acl_endpoint.go Outdated Show resolved Hide resolved
nomad/acl_endpoint.go Outdated Show resolved Hide resolved
nomad/acl_endpoint.go Show resolved Hide resolved
nomad/acl_endpoint.go Outdated Show resolved Hide resolved
Co-authored-by: James Rasell <[email protected]>
@mismithhisler mismithhisler added backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line labels Jan 23, 2025
@mismithhisler mismithhisler merged commit d621211 into main Jan 23, 2025
41 checks passed
@mismithhisler mismithhisler deleted the f-add-verbose-logging-option-to-auth-methods branch January 23, 2025 16:40
tgross pushed a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSO: add debug logging when translating claims via binding rules
2 participants