-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: adds option to enable verbose logging during sso #24892
Merged
mismithhisler
merged 5 commits into
main
from
f-add-verbose-logging-option-to-auth-methods
Jan 23, 2025
Merged
auth: adds option to enable verbose logging during sso #24892
mismithhisler
merged 5 commits into
main
from
f-add-verbose-logging-option-to-auth-methods
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please feel free to be critical of the log messages I've added, and if you think they are/aren't helpful. |
jrasell
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thanks for doing this.
I've added some comments inline which I think would be good to figure out before merging.
Co-authored-by: James Rasell <[email protected]>
jrasell
approved these changes
Jan 23, 2025
6 tasks
tgross
pushed a commit
that referenced
this pull request
Jan 23, 2025
Co-authored-by: James Rasell <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/ent/1.7.x+ent
Changes are backported to 1.7.x+ent
backport/ent/1.8.x+ent
Changes are backported to 1.8.x+ent
backport/1.9.x
backport to 1.9.x release line
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to enable a verbose logger when configuring an auth-method. This logger will output token claims and information related to how claims are mapped to Nomad identities, and how those identities map to Nomad binding-rules and role/policies.
Testing & Reproduction steps
Create an auth-method and enable the
VerboseLogging
option. Then start the process of configuring SSO and see the logs.Links
Fixes GH #16360
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.