Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Namespace added to example test in exec window #20218

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[ui] Namespace added to example test in exec window #20218

merged 1 commit into from
Mar 25, 2024

Conversation

philrenaud
Copy link
Contributor

Adds a -namespace $NAMESPACEID string to the example we show when you exec in a task in the Nomad web UI (when not in the default namespace)

image

Resolves #20213

@philrenaud philrenaud requested review from lgfa29 and gulducat March 25, 2024 16:44
@philrenaud philrenaud self-assigned this Mar 25, 2024
@philrenaud philrenaud linked an issue Mar 25, 2024 that may be closed by this pull request
Web UI exec command doesn't consider namespaces #20213
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

Ember Test Audit comparison

main 40a55ed change
passes 1549 1550 +1
failures 0 0 0
flaky 0 0 0
duration 10m 44s 889ms 10m 36s 645ms -08s 244ms

lgfa29
lgfa29 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing a changelog entry 😄

@philrenaud philrenaud force-pushed the 20213-web-ui-exec-command-doesnt-consider-namespaces branch from f6922f1 to 6c85d42 Compare March 25, 2024 19:03
@philrenaud philrenaud added backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line labels Mar 25, 2024
@philrenaud philrenaud force-pushed the 20213-web-ui-exec-command-doesnt-consider-namespaces branch from 6c85d42 to 40a55ed Compare March 25, 2024 19:56
@philrenaud philrenaud merged commit fee242c into main Mar 25, 2024
15 checks passed
@philrenaud philrenaud deleted the 20213-web-ui-exec-command-doesnt-consider-namespaces branch March 25, 2024 21:02
This was referenced Mar 25, 2024
Closed
Closed
philrenaud added a commit that referenced this pull request Mar 26, 2024
@philrenaud
Namespace added to example test in exec window (#20218)
e8e6660
philrenaud added a commit that referenced this pull request Mar 26, 2024
@philrenaud
Namespace added to example test in exec window (#20218)
ced3f19
philrenaud added a commit that referenced this pull request Apr 18, 2024
@philrenaud
Namespace added to example test in exec window (#20218)
a5bb76e
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

@gulducat gulducat Awaiting requested review from gulducat

Assignees

@philrenaud philrenaud

Labels
backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web UI exec command doesn't consider namespaces
2 participants
@philrenaud @lgfa29