Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Small-screen styles for exec window #19332

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

philrenaud
Copy link
Contributor

Vertically stacks things so they look nicer on narrow screens

image

Resolves #19331

@philrenaud philrenaud requested a review from angrycub December 6, 2023 16:24
@philrenaud philrenaud self-assigned this Dec 6, 2023
@philrenaud philrenaud linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Dec 6, 2023

Ember Test Audit comparison

main be4e884 change
passes 1540 1540 0
failures 0 0 0
flaky 0 0 0
duration 10m 49s 001ms 10m 54s 148ms +05s 147ms

@philrenaud philrenaud added the backport/1.7.x backport to 1.7.x release line label Dec 8, 2023
@@ -155,3 +155,24 @@
}
}
}
// Media query for small screens
@media (max-width: 768px) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cursory glance tells me we dont have any scss variables for this size, but might be nice so we have fewer magic strings (obviously not a blocker)

@philrenaud philrenaud merged commit 268e92e into main Dec 11, 2023
11 checks passed
@philrenaud philrenaud deleted the 19331-ui-mobile-view-for-exec-terminal-window branch December 11, 2023 14:42
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.7.x backport to 1.7.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] Mobile view for Exec terminal window
2 participants