[ui] Nicer comment styles in example jobs #19037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrycub
approved these changes
Nov 8, 2023
Comment on lines
51
to
60
| data = <<EOF | ||
| <h1>Hello, Nomad!</h1> | ||
| <ul> | ||
| <li>Task: {{env "NOMAD_TASK_NAME"}}</li> | ||
| <li>Group: {{env "NOMAD_GROUP_NAME"}}</li> | ||
| <li>Job: {{env "NOMAD_JOB_NAME"}}</li> | ||
| <li>Metadata value for foo: {{env "NOMAD_META_foo"}}</li> | ||
| <li>Currently running on port: {{env "NOMAD_PORT_www"}}</li> | ||
| </ul> | ||
| <h1>Hello, Nomad!</h1> | ||
| <ul> | ||
| <li>Task: {{env "NOMAD_TASK_NAME"}}</li> | ||
| <li>Group: {{env "NOMAD_GROUP_NAME"}}</li> | ||
| <li>Job: {{env "NOMAD_JOB_NAME"}}</li> | ||
| <li>Metadata value for foo: {{env "NOMAD_META_foo"}}</li> | ||
| <li>Currently running on port: {{env "NOMAD_PORT_www"}}</li> | ||
| </ul> | ||
| EOF |
There was a problem hiding this comment.
You might be able to retain the spec as written using <<-EOF instead of <<EOF
Ember Test Audit comparison
|
philrenaud
force-pushed
the
f-ui/example-job-comment-notation
branch
from
b97030f to
7c77edc
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps out the
//for#comment prefixes in our job template strings (which eventually are expressed as HCL) for highlighting reasons, among others.Old:
New: