-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] node eligibilty taken into consideration when clients list filtered to "ready" #18607
[ui] node eligibilty taken into consideration when clients list filtered to "ready" #18607
Conversation
Ember Test Audit comparison
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this likely aligns with user intent, as our placing "ready" next to "ineligible" in the drop-down, with no other explicitly positive option, suggests that "ready" = "eligible" 👍
62d8c0c
to
05e7746
Compare
1e790a8
to
47af381
Compare
d511bb3
to
7d69f56
Compare
5e71595
to
8495b46
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
On our clients list page, we abstract node readiness, eligibility, and draining status into one
State
filter.This leads to situations where a user selects "Ready" and expects to see eligible nodes, but a node can technically be "ready" by status and marked ineligible for new tasks.
This seems confusing with the abstraction in place. As such, selecting "Ready" will not filter out any ineligible nodes.
In resolving this, we've made some updates to the way the State filter works, relative to the others:
We realize this creates an inconsistency, but felt like this represents a practical approach to making state filter behaviour here work as expected.
Resolves #18593