parse ACL token from authorization header #12534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
relevant consul issue hashicorp/consul#4483 |
tgross
requested review from
schmichael and
tgross
and removed request for
schmichael
tgross
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
LGTM! Thanks @kevinschoonover. I'm going to push a changelog entry commit onto this PR and then we'll get it merged for the next planned release of Nomad (1.3.2).
GitHub won't let me add a commit to this PR for some reason, so I'll add the changelog independently.
tgross
added a commit
that referenced
this pull request
Jun 6, 2022
tgross
added a commit
that referenced
this pull request
Jun 6, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for reading ACL token from the RFC6750 Bearer token (
Authorization: Bearer <token>).The code samples / documentation were taken from Consul:
https://github.com/hashicorp/consul/blob/973d2d0f9a2d32f6f3eae506c2b5b89f98007b58/agent/http.go#L1021-L1041
https://github.com/hashicorp/consul/blob/1d817f683a4922756db44b991428cd5f582ea6ae/website/content/api-docs/index.mdx
Background behind this is I'm using prometheus static_config to scrape metrics from nomad and the static_config configuration doesn't support custom headers, only authorization tokens. This would allow me to properly embed and use the token.
I have yet to test the locally, but will update here when I have a chance to do. Wanted to start the conversation of if this is something y'all wanted to support.
Let me know your thoughts and if there is anything else I should add!