scheduler: persist changes to reconnected allocs

Reconnected allocs have a new AllocState entry that must be persisted by
the plan applier.

Author: lgfa29

scheduler/generic_sched.go

@@ -415,6 +415,12 @@ func (s *GenericScheduler) computeJobAllocs() error {
 		s.plan.AppendUnknownAlloc(update)
 	}
 
+	// Handle reconnect updates.
+	// Reconnected allocs have a new AllocState entry.
+	for _, update := range results.reconnectUpdates {
+		s.ctx.Plan().AppendAlloc(update, nil)
+	}
+
 	// Handle the in-place updates
 	for _, update := range results.inplaceUpdate {
 		if update.DeploymentID != s.deployment.GetID() {

scheduler/reconcile.go

@@ -1206,7 +1206,7 @@ func (a *allocReconciler) computeReconnecting(reconnecting allocSet) {
 		// Use a copy to prevent mutating the object from statestore.
 		reconnectedAlloc := alloc.Copy()
 		reconnectedAlloc.AppendState(structs.AllocStateFieldClientStatus, alloc.ClientStatus)
-		a.result.reconnectUpdates[alloc.ID] = reconnectedAlloc
+		a.result.reconnectUpdates[reconnectedAlloc.ID] = reconnectedAlloc
 	}
 }