Skip to content

Commit 83a75b3

Browse files
authored
Merge pull request #6144 from hashicorp/b-docker-exec
docker: Fix issue where an exec may never timeout
2 parents 478195a + a921c21 commit 83a75b3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/docker/driver.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1323,7 +1323,7 @@ func (d *Driver) ExecTaskStreaming(ctx context.Context, taskID string, opts *dri
13231323
const execTerminatingTimeout = 3 * time.Second
13241324
start := time.Now()
13251325
var res *docker.ExecInspect
1326-
for res == nil || res.Running || time.Since(start) > execTerminatingTimeout {
1326+
for (res == nil || res.Running) && time.Since(start) <= execTerminatingTimeout {
13271327
res, err = client.InspectExec(exec.ID)
13281328
if err != nil {
13291329
return nil, fmt.Errorf("failed to inspect exec result: %v", err)

0 commit comments

Comments
 (0)