Skip to content

Commit 5581515

Browse files
committed
Remove template-only component setting
The ClientDetail.attributesTable assertion was failing because it becoming a template-only component meant that the data-test-attributes selector had no element to attach to. Having the edition set to Octane in package.json causes an error to be thrown when template-only-glimmer-components is turned off, so it’ll have to go for now.
1 parent 50e3bd4 commit 5581515

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

ui/config/optional-features.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"application-template-wrapper": false,
33
"default-async-observers": true,
44
"jquery-integration": false,
5-
"template-only-glimmer-components": true
5+
"template-only-glimmer-components": false
66
}

ui/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,6 @@
136136
"engines": {
137137
"node": "10.* || >= 12"
138138
},
139-
"ember": {
140-
"edition": "octane"
141-
},
142139
"private": true,
143140
"ember-addon": {
144141
"paths": [

0 commit comments

Comments
 (0)