Release hcp vault-secrets integrations and rotating/dynamic secrets #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mercedesbh
requested review from
averche,
VinnyHC,
austingebauer,
jasonpilz and
pierluc-codes
raymonstah
reviewed
Oct 8, 2024
Comment on lines
+64
to
+73
| Flags: cmd.Flags{ | ||
| Local: []*cmd.Flag{ | ||
| { | ||
| Name: "type", | ||
| DisplayValue: "TYPE", | ||
| Description: "The type of the integration to read.", | ||
| Value: flagvalue.Simple("", &opts.Type), | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Sorry for getting to this review late, but I was curious why we needed the --type flag to read an integration!
Could all of the providers use the generic read endpoint instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR encompasses the work for epic https://hashicorp.atlassian.net/browse/VAULT-28135 to gain HCP CLI Parity for Vault Secrets. It includes:
All changes in this PR have already gone through code review to make into this branch. Those PRs are here:
How I've tested this PR:
This PR includes unit tests, and has also been manually tested during a project bug bash
How I expect reviewers to test this PR:
make go/buildChecklist: