Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TCK): Add AccountUpdate method #2493

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Conversation

ivaylogarnev-limechain
Copy link
Contributor

Description:
This PR implements the AccountUpdate JSON-RPC method and successfully validated its functionality through comprehensive tests within the TCK project.

Related issue(s):
#2437

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

0xivanov
0xivanov previously approved these changes Aug 29, 2024
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agadzhalov
agadzhalov previously approved these changes Aug 29, 2024
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isavov isavov force-pushed the feat/2437-tck-account-update branch from 58e20f1 to d8ebdc8 Compare August 30, 2024 08:33
Copy link

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit dd8431c into main Aug 30, 2024
13 checks passed
@0xivanov 0xivanov deleted the feat/2437-tck-account-update branch August 30, 2024 14:04
@ivaylonikolov7 ivaylonikolov7 mentioned this pull request Sep 12, 2024
ivaylogarnev-limechain added a commit that referenced this pull request Sep 19, 2024
* feat: Added accountUpdate JSONRPC method in the TCK and the relevant interfaces

Signed-off-by: ivaylogarnev-limechain <[email protected]>

* refactor: Deleted some unnecessary comments, added a constant

Signed-off-by: ivaylogarnev-limechain <[email protected]>

* fix: Added timeout the TokenNftsUpdateTransactionIntegrationTest before function

Signed-off-by: ivaylogarnev-limechain <[email protected]>

* fix: Fixed assertion in TokenNftsUpdateTransactionIntegrationTest.ts

Signed-off-by: ivaylogarnev-limechain <[email protected]>

---------

Signed-off-by: ivaylogarnev-limechain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK-JS: Implement JSON-RPC methods for AccountUpdateTransaction
4 participants