Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate actual receiptsRoot when possible #2667

Closed
Tracked by #2709
georgi-l95 opened this issue Jul 3, 2024 · 0 comments · Fixed by #2798
Closed
Tracked by #2709

Calculate actual receiptsRoot when possible #2667

georgi-l95 opened this issue Jul 3, 2024 · 0 comments · Fixed by #2798
Assignees
Labels
dev tools Features enabling dev tool integration enhancement New feature or request
Milestone

Comments

@georgi-l95
Copy link
Member

georgi-l95 commented Jul 3, 2024

Problem

Currently when we return block information, we don't include actual receiptsRoot, this is because Hedera is not using Merkle Patricia trie. However this can be easly calucalted during processing of the request. Returning real receiptsRoot can help tools, as well as help developers use merkle proofs of inclusion.

Solution

Taking a look at how calculating receiptsRoot is done in the javascript execution client for ethereum can help us do it here as well. More information about the implementation can be found here.

@georgi-l95 georgi-l95 added enhancement New feature or request dev tools Features enabling dev tool integration labels Jul 3, 2024
@georgi-l95 georgi-l95 moved this from Backlog to Sprint Backlog in Smart Contract Sprint Board Jul 3, 2024
@georgi-l95 georgi-l95 moved this from Sprint Backlog to Backlog in Smart Contract Sprint Board Jul 8, 2024
@Nana-EC Nana-EC moved this from Backlog to Sprint Backlog in Smart Contract Sprint Board Jul 17, 2024
@natanasow natanasow self-assigned this Aug 5, 2024
@natanasow natanasow moved this from Sprint Backlog to Tasks In Progress in Smart Contract Sprint Board Aug 5, 2024
@natanasow natanasow added this to the 0.54.0 milestone Aug 8, 2024
@quiet-node quiet-node modified the milestones: 0.54.0, 0.55.0 Aug 12, 2024
@natanasow natanasow moved this from Tasks In Progress to In Review in Smart Contract Sprint Board Aug 14, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev tools Features enabling dev tool integration enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants