Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use and references to mock MirrorNode #253

Closed
Nana-EC opened this issue Jun 22, 2022 · 0 comments · Fixed by #374
Closed

Remove use and references to mock MirrorNode #253

Nana-EC opened this issue Jun 22, 2022 · 0 comments · Fixed by #374
Assignees
@lukelee-sl
Labels
enhancement New feature or request P3
Milestone
0.5.0

Comments

@Nana-EC
Copy link
Collaborator

Nana-EC commented Jun 22, 2022

Problem

Initially to get the relay going we had a mock implementation of the MirrorNode.
Eventually this got reduced down to caching logic for blocks which is used in place of calling the real MirrorNode

Solution

Remove file and references to MirrorNode.ts

Alternatives

No response
@Nana-EC Nana-EC added enhancement New feature or request P2 labels Jun 22, 2022
@Nana-EC Nana-EC added this to the 0.3.0 milestone Jun 22, 2022
@Nana-EC Nana-EC modified the milestones: 0.3.0, 0.4.0 Jun 30, 2022
@Nana-EC Nana-EC modified the milestones: 0.4.0, 0.5.0 Jul 14, 2022
@Nana-EC Nana-EC added P3 and removed P2 labels Jul 18, 2022
@Nana-EC Nana-EC modified the milestones: 0.5.0, 0.1.0 Jul 18, 2022
@lukelee-sl lukelee-sl self-assigned this Jul 22, 2022
@lukelee-sl lukelee-sl mentioned this issue Jul 22, 2022
Merged
2 tasks
@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukelee-sl lukelee-sl

Labels
enhancement New feature or request P3
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

remove mirrorNode.ts and dependencies hashgraph/hedera-json-rpc-relay
2 participants
@Nana-EC @lukelee-sl