Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client error classes to streamline error handling #213

Closed
Nana-EC opened this issue Jun 15, 2022 · 0 comments · Fixed by #382
Closed

Add client error classes to streamline error handling #213

Nana-EC opened this issue Jun 15, 2022 · 0 comments · Fixed by #382
Assignees
Labels
enhancement New feature or request P3
Milestone

Comments

@Nana-EC
Copy link
Collaborator

Nana-EC commented Jun 15, 2022

Problem

Currently both clients (sdk and mirrorNode) can send a variation of errors.
These leak info, make logs large and also vary in nature so it's hard to sometime differentiate and infrom how the eth_x calls should handle them.

Solution

We should add a SDKClientError and MirrorNodeClientError class that consumes the returned errors and captures the value information e.g. type, status code etc.

This should be thrown by the clients, checked for by eth class and managed as needed.
This way server logs and details are very small and specific and don't leak eth or client info

Alternatives

No response

@Nana-EC Nana-EC added enhancement New feature or request P2 labels Jun 15, 2022
@Nana-EC Nana-EC added this to the 0.3.0 milestone Jun 20, 2022
@Nana-EC Nana-EC modified the milestones: 0.3.0, 0.4.0 Jun 30, 2022
@Nana-EC Nana-EC added P3 and removed P2 labels Jun 30, 2022
@Nana-EC Nana-EC modified the milestones: 0.4.0, 0.5.0 Jul 14, 2022
@Nana-EC Nana-EC removed this from the 0.5.0 milestone Jul 18, 2022
@lukelee-sl lukelee-sl self-assigned this Jul 22, 2022
@Nana-EC Nana-EC added this to the 0.5.0 milestone Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants