From 0f9cd4990b42f898d3c9e2b6a874bb4b4b2a0f17 Mon Sep 17 00:00:00 2001 From: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com> Date: Wed, 22 May 2024 07:19:16 -0700 Subject: [PATCH 1/2] Fix description of authorization of Hedera account Description is just wrong: Nothing is signed, a signature is verifed as usual. Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com> --- HIP/hip-632.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HIP/hip-632.md b/HIP/hip-632.md index 85dc27060..e4b0894f9 100644 --- a/HIP/hip-632.md +++ b/HIP/hip-632.md @@ -63,7 +63,7 @@ This function is similar to using the ECRECOVER precompile function. Ethereum u * If true, extract v, r and s and run ECRECOVER(messageHash, v, r, s) and determine if the result matches any of the virtual address on the account. Return true if any matching address is found if given a Hedera Account ID. If given an Ethereum address, the recovered address must match the given address. 3. If length of signatureBlob is 64 bytes in length * Retrieve the Hedera address. Determine if there is a single key associated with the Hedera Accound ID. If not return false. - * If there is a single key, sign the messageHash and return true if the signature matches the signatureBlob. + * If there is a single key, verify that the signature (the signatureBlob) signs the message hash and is attested by the account. ### `isAuthorized(address, messageHash, signatureBlob)` Function Usage This function is used for Hedera account (non Ethereum) signature validation. It handles the more complex signature types which are available with Hedera accounts. One or more signatures will be encoded in protobuf format into the signatureBlob. The precompile function will look up the keys for the account and determine if the signatures passed in via the signatureBlob satisfy the signing requirements for the account. For example, if the account has a threshhold key of needing 3 out of 4 signatures,the precompile function will sign the messageHash with each key on the account and determine if at least 3 signatures in the signatureBlob matches. From 8e948147901df26072f0a6f347d079b61af99258 Mon Sep 17 00:00:00 2001 From: Michael Garber Date: Wed, 22 May 2024 11:15:25 -0400 Subject: [PATCH 2/2] Update hip-632.md updated date Signed-off-by: Michael Garber --- HIP/hip-632.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HIP/hip-632.md b/HIP/hip-632.md index e4b0894f9..01d72e645 100644 --- a/HIP/hip-632.md +++ b/HIP/hip-632.md @@ -10,7 +10,7 @@ status: Accepted last-call-date-time: 2023-01-10T07:00:00Z created: 2022-11-28 discussions-to: https://github.com/hashgraph/hedera-improvement-proposal/discussions/638 -updated: 2022-12-13, 2022-12-20, 2023-01-03, 2023-01-18 +updated: 2024-05-22 requires: 631 ---