Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add essential checks on (cluster)flow and (cluster)output #7064

Open
w13915984028 opened this issue Nov 28, 2024 · 3 comments
Open
Assignees
Labels
area/logging candidate/v1.5.0 kind/enhancement Issues that improve or augment existing functionality
Milestone

Comments

@w13915984028
Copy link
Member

w13915984028 commented Nov 28, 2024

Is your enhancement related to a problem? Please describe.

The mis-matching of (cluster)flow and (cluster)output may cause the logging related pods failed to be deployed.

The resources dangling scenarios:
(1) The (cluster)output is removed but it's referring (cluster)flow is still there
(2) The (cluster)flow is added but it's referring (cluster)output is not existing

Describe the solution you'd like

(1) When create/modify a (cluster)flow, check it's (cluster) flow is existing
(2) When delete a (cluster)output, check it's referring (cluster)flow is gone

Describe alternatives you've considered

Additional context

@harvesterhci-io-github-bot
Copy link
Collaborator

harvesterhci-io-github-bot commented Jan 29, 2025

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at: Validate Flow and ClusterFlow when enabling rancher-logging addon #7462

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@harvesterhci-io-github-bot
Copy link
Collaborator

Automation e2e test issue: harvester/tests#1822

@w13915984028
Copy link
Member Author

Test plan: on PR #7462 description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging candidate/v1.5.0 kind/enhancement Issues that improve or augment existing functionality
Projects
Development

No branches or pull requests

2 participants