Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v1.4] [ENHANCEMENT][GUI] Move enable CPU Pinning checkbox position in template config page #6937

Closed
harvesterhci-io-github-bot opened this issue Nov 4, 2024 · 3 comments
Assignees
Labels
area/ui Harvester UI kind/enhancement Issues that improve or augment existing functionality not-require/test-plan Skip to create a e2e automation test issue
Milestone

Comments

@harvesterhci-io-github-bot
Copy link
Collaborator

backport the issue #6879

@harvesterhci-io-github-bot harvesterhci-io-github-bot added area/ui Harvester UI backport-to/v1.4 kind/enhancement Issues that improve or augment existing functionality not-require/test-plan Skip to create a e2e automation test issue area/ui-extension Harvester UI extension for managed and standalone Harvester labels Nov 4, 2024
@harvesterhci-io-github-bot harvesterhci-io-github-bot added this to the v1.4.0 milestone Nov 4, 2024
@harvesterhci-io-github-bot
Copy link
Collaborator Author

harvesterhci-io-github-bot commented Nov 5, 2024

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at:

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@a110605
Copy link

a110605 commented Nov 5, 2024

Backport PR merged. harvester/dashboard#1221

@a110605 a110605 removed the area/ui-extension Harvester UI extension for managed and standalone Harvester label Nov 5, 2024
@bk201 bk201 changed the title [backport v1.4] [ENHANCEMENT][GUI] Move enable CPU Pinnging checkbox position in template config page [backport v1.4] [ENHANCEMENT][GUI] Move enable CPU Pinning checkbox position in template config page Nov 7, 2024
@TachunLin
Copy link

Verified fixed on v1.4-eaf3009a-head. (24/11/09). Close this issue.

Result

$\color{green}{\textsf{PASS}}$ Test enable CPU Pinning on the modified default virtual machine template $~~$
  1. Modify the default template, check the Enable CPU Pinging

  2. Launch instance from the newly created template

image

image

  1. CPU Pinning vm can request specific core cpu on host for this VM
harv14-241110:~ # kubectl exec virt-launcher-test-modified-template-t74hr -- virsh dumpxml default_test-modified-template | awk "/<cputune>/,/<\/cputune>/"
  <cputune>
    <vcpupin vcpu='0' cpuset='1'/>
    <vcpupin vcpu='1' cpuset='2'/>
  </cputune>
$\color{green}{\textsf{PASS}}$ Test enable CPU Pinning when create a new virtual machine template $~~$
  1. Create a new virtual machine template and check the Enable CPU Pinning in the Advanced Options
    image

  2. Create a new vm and select the newly create template
    image

  3. CPU Pinning vm can request specific core cpu on host to it's vcpu

harv14-241110:~ # kubectl exec virt-launcher-new-cpu-pinning-dmpkx -- virsh dumpxml default_new-cpu-pinning | awk "/<cputune>/,/<\/cputune>/"
  <cputune>
    <vcpupin vcpu='0' cpuset='1'/>
    <vcpupin vcpu='1' cpuset='2'/>
  </cputune>
$\color{green}{\textsf{PASS}}$ Test disable CPU Pinning when create a new virtual machine template $~~$
  1. Create a new virtual machine template and do not check the Enable CPU Pinning in the Advanced Options

image

image

  1. Create a new vm and select the newly create template

image

  1. CPU Pinning vm don't request specific core cpu on host to it's vcpu
harv14-241110:~ # kubectl exec virt-launcher-non-cpu-pinning-wl56b -- virsh dumpxml default_non-cpu-pinning | awk "/<cputune>/,/<\/cputune>/"
harv14-241110:~ #

Test Information

  • Test Environment: Single node kvm machine
  • Harvester version: v1.4-eaf3009a-head. (24/11/09)

Verify Steps

Enable CPU Pinning on existing virtual machine template
  1. Enable CPU Manager on the host menu item
    image

  2. Modify template to create a new version of raw-image-base-version
    image

  3. Check the Enable CPU Pinning in the Advanced Options and Save
    image
    image

  4. Launch instance from the newly created template

image

image

  1. Check the vm can started in Running

  2. CPU Pinning vm can request specific core cpu on host to it's vcpu

harv14-241110:~ # kubectl exec virt-launcher-test-modified-template-t74hr -- virsh dumpxml default_test-modified-template | awk "/<cputune>/,/<\/cputune>/"
  <cputune>
    <vcpupin vcpu='0' cpuset='1'/>
    <vcpupin vcpu='1' cpuset='2'/>
  </cputune>
Enable CPU Pinning when create a new virtual machine template
  1. Create a new virtual machine template

  2. Check the Enable CPU Pinning in the Advanced Options and Save
    image

  3. Create a new vm and select the newly create template
    image

  4. Check the vm can started in Running

image

  1. CPU Pinning vm can request specific core cpu on host to it's vcpu
harv14-241110:~ # kubectl exec virt-launcher-new-cpu-pinning-dmpkx -- virsh dumpxml default_new-cpu-pinning | awk "/<cputune>/,/<\/cputune>/"
  <cputune>
    <vcpupin vcpu='0' cpuset='1'/>
    <vcpupin vcpu='1' cpuset='2'/>
  </cputune>
Disable CPU Pinning when create a new virtual machine template
  1. Create a new virtual machine template

  2. Do not check the Enable CPU Pinning in the Advanced Options and Save

image

image

  1. Create a new vm and select the newly create template

image

  1. Check the vm can started in Running

image

  1. CPU Pinning vm don't request specific core cpu on host to it's vcpu
harv14-241110:~ # kubectl exec virt-launcher-non-cpu-pinning-wl56b -- virsh dumpxml default_non-cpu-pinning | awk "/<cputune>/,/<\/cputune>/"
harv14-241110:~ #

@github-project-automation github-project-automation bot moved this from New to Scheduled/Closed in Feature Request Review Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Harvester UI kind/enhancement Issues that improve or augment existing functionality not-require/test-plan Skip to create a e2e automation test issue
Projects
Status: Scheduled/Closed
Development

No branches or pull requests

3 participants