Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Schedule VM Backup Misc Update #6621

Closed
WebberHuang1118 opened this issue Sep 24, 2024 · 4 comments
Closed

[ENHANCEMENT] Schedule VM Backup Misc Update #6621

WebberHuang1118 opened this issue Sep 24, 2024 · 4 comments
Assignees
Labels
kind/enhancement Issues that improve or augment existing functionality priority/1 Highly recommended to fix in this release
Milestone

Comments

@WebberHuang1118
Copy link
Member

Is your enhancement related to a problem? Please describe.

  • Improve webhook message for multiple svmbackup creation for the same vm
  • Suspend schedule and delete the LH backup if the volumesnapshot is in an error state but LH backup keeps reconciling
@WebberHuang1118 WebberHuang1118 added the kind/enhancement Issues that improve or augment existing functionality label Sep 24, 2024
@bk201 bk201 added this to the v1.4.0 milestone Sep 24, 2024
@bk201 bk201 added the priority/1 Highly recommended to fix in this release label Sep 24, 2024
@harvesterhci-io-github-bot
Copy link
Collaborator

harvesterhci-io-github-bot commented Sep 24, 2024

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at: enhancement: schedule vm backup misc update #6622 (comment)

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at: enhancement: schedule vm backup misc update #6622

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@harvesterhci-io-github-bot
Copy link
Collaborator

Automation e2e test issue: harvester/tests#1546

@w13915984028
Copy link
Member

w13915984028 commented Oct 25, 2024

Test report: PASS

(1) Create 2 similar backup for same VM:

got error:

admission webhook "validator.harvesterhci.io" denied the request: same granularity as schedule svmbackup-vm1-running and offset less than 10m0s

image

(2) Suspend a schedule and create a new one
got error:

admission webhook "validator.harvesterhci.io" denied the request: VM default/vm1-running already has backup schedule

image

image

(3) Create schedule type snapshot after an existing schedule type backup
got error:

admission webhook "validator.harvesterhci.io" denied the request: VM default/vm1-running already has backup schedule

image

(4) Change the backup source vm via Edit Yaml (not allowed from UI config directly)
got error:

admission webhook "validator.harvesterhci.io" denied the request: source vm can't be changed

image

(5) Disable the backup target to test the status of schedule
(5.1) Create a NFS type schedulebackup
(5.2) Stop the NFS server
(5.3) Wait until the schedule is triggered, then observe:

image

image

the above meets the expectation

(5.4) Start the NFS server
(5.5) Manually delete the error backup
image

(5.6) But the schedulebackup still shows below message
image

5.6 could be handled via #6876

@w13915984028
Copy link
Member

The enhancement is done, thanks @WebberHuang1118 .

A minor fix #6876 could be addressed in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues that improve or augment existing functionality priority/1 Highly recommended to fix in this release
Projects
None yet
Development

No branches or pull requests

4 participants