Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] generate_addon_csi.sh uses wrong kubeconfig server #6118

Closed
dfaltum opened this issue Jul 3, 2024 · 6 comments
Closed

[BUG] generate_addon_csi.sh uses wrong kubeconfig server #6118

dfaltum opened this issue Jul 3, 2024 · 6 comments
Assignees
Labels
area/guest-cluster-csi-driver Harvester CSI driver for guest cluster kind/bug Issues that are defects reported by users or that we know have reached a real release priority/1 Highly recommended to fix in this release reproduce/always Reproducible 100% of the time severity/2 Function working but has a major issue w/o workaround (a major incident with significant impact)
Milestone

Comments

@dfaltum
Copy link

dfaltum commented Jul 3, 2024

Describe the bug
If you're following this guide, you may experience some trouble with the generated kubeconfig.

To Reproduce
If you run this script via Rancher provided kubeconfig or via SSH from the Harvester CP node, the following line will give you an incorrect kubectl server. For example:

++ kubectl config view -o 'jsonpath={.clusters[?(@.name == "default")].cluster.server}'
+ ENDPOINT=https://127.0.0.1:6443

Expected behavior
The kubeconfig file should contain an IP address that is reachable from outside of the cluster.

@dfaltum dfaltum added kind/bug Issues that are defects reported by users or that we know have reached a real release reproduce/needed Reminder to add a reproduce label and to remove this one severity/needed Reminder to add a severity label and to remove this one labels Jul 3, 2024
@bk201 bk201 added the require/doc Improvements or additions to documentation label Jul 4, 2024
@bk201 bk201 added priority/1 Highly recommended to fix in this release severity/2 Function working but has a major issue w/o workaround (a major incident with significant impact) and removed severity/needed Reminder to add a severity label and to remove this one labels Jul 4, 2024
@bk201 bk201 added this to the v1.4.0 milestone Jul 4, 2024
@Vicente-Cheng
Copy link
Contributor

Hi @dfaltum,

Thanks for raising this issue.
I do some checks with that.

I would like to know where you executed this script.
On the Harvester cluster or the downstream cluster?

I thought the document was not very clear because the purpose was that we should run this script on the downstream cluster. And using the kubeconfig of the host harvester cluster.

@dfaltum
Copy link
Author

dfaltum commented Jul 5, 2024

Hi @Vicente-Cheng,
First, I've tried the script with an SSH login to the Harvester cluster. I also tried using the Harvester kubeconfig file provided by Rancher. So both approaches are problematic.

@Vicente-Cheng
Copy link
Contributor

Hi @dfaltum,

Thanks for the explanation.
I checked with the latest kubeconfig download from the rancher UI.

You are right. This should be fixed by your PR.
Thanks again for your fix!

@Vicente-Cheng Vicente-Cheng added reproduce/always Reproducible 100% of the time area/guest-cluster-csi-driver Harvester CSI driver for guest cluster and removed require/doc Improvements or additions to documentation reproduce/needed Reminder to add a reproduce label and to remove this one labels Jul 8, 2024
@harvesterhci-io-github-bot
Copy link
Collaborator

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at:

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@harvesterhci-io-github-bot
Copy link
Collaborator

Automation e2e test issue: harvester/tests#1363

@dfaltum
Copy link
Author

dfaltum commented Jul 17, 2024

harvester/harvester-csi-driver#40 merged

@dfaltum dfaltum closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/guest-cluster-csi-driver Harvester CSI driver for guest cluster kind/bug Issues that are defects reported by users or that we know have reached a real release priority/1 Highly recommended to fix in this release reproduce/always Reproducible 100% of the time severity/2 Function working but has a major issue w/o workaround (a major incident with significant impact)
Projects
None yet
Development

No branches or pull requests

4 participants