Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v1.3] [ENHANCEMENT] Adding dig to Harvester #5814

Closed
harvesterhci-io-github-bot opened this issue May 15, 2024 · 4 comments
Closed
Assignees
Labels
area/os Harvester OS related (ex: SLE Micro) kind/enhancement Issues that improve or augment existing functionality not-require/test-plan Skip to create a e2e automation test issue priority/1 Highly recommended to fix in this release
Milestone

Comments

@harvesterhci-io-github-bot
Copy link
Collaborator

backport the issue #5305

@harvesterhci-io-github-bot harvesterhci-io-github-bot added area/os Harvester OS related (ex: SLE Micro) kind/enhancement Issues that improve or augment existing functionality not-require/test-plan Skip to create a e2e automation test issue priority/1 Highly recommended to fix in this release labels May 15, 2024
@harvesterhci-io-github-bot harvesterhci-io-github-bot added this to the v1.3.1 milestone May 15, 2024
@harvesterhci-io-github-bot
Copy link
Collaborator Author

harvesterhci-io-github-bot commented May 16, 2024

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Check the dig command present in the os.
  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at:

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@irishgordo irishgordo self-assigned this May 16, 2024
@irishgordo
Copy link
Contributor

Looks great 👍 😄 on v1.3-head:

rancher@node7-v13head:~> cat /etc/os-release 
NAME="SLE Micro"
VERSION="5.4"
VERSION_ID="5.4"
PRETTY_NAME="Harvester v1.3"
ID="sle-micro-rancher"
ID_LIKE="suse"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:suse:sle-micro-rancher:5.4"
VARIANT="Harvester"
VARIANT_ID="Harvester-v1.3-20240515"
GRUB_ENTRY_NAME="Harvester v1.3"

Version: master-f38da5f7-head

Thanks @tserong
Gonna go ahead and close this out

Screenshot from 2024-05-16 14-02-56

@irishgordo
Copy link
Contributor

Re-Opening, need to revalidate due to:
harvester/harvester-installer#737

@irishgordo
Copy link
Contributor

This looks good on Version: v1.3-95b4f9dc-head - during re-validation - thanks again @tserong
Screenshot from 2024-05-22 11-56-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/os Harvester OS related (ex: SLE Micro) kind/enhancement Issues that improve or augment existing functionality not-require/test-plan Skip to create a e2e automation test issue priority/1 Highly recommended to fix in this release
Projects
None yet
Development

No branches or pull requests

3 participants