[ENHANCEMENT] Prohibit users from resizing volume when vm is stopping.

[Yu-Jack]

Is your enhancement related to a problem? Please describe.

Currently, this PR #4794 solution doesn't fix the problem which users could resize the volume when vm is stopping.

When we stop vm from kubevirt, its RunStrategy and PrintableStatus will be like this:

• RunStrategy: RerunOnFailure, , PrintableStatus: Running
• RunStrategy: Halted, , PrintableStatus: Running
• RunStrategy: Halted, PrintableStatus: Stopping
• VMI still exists
• At this moment, it takes some time to stop vm, so users could edit vm config to resize volume.
• RunStrategy: Halted, PrintableStatus: Stopped
• VMI is gone

Describe the solution you'd like

We should change condition order, move PrintableStatus != Stopped to first one.

Describe alternatives you've considered

Additional context

[harvesterhci-io-github-bot]

added backport-needed/1.2.2 issue: #5408.

[harvesterhci-io-github-bot]

added backport-needed/1.3.1 issue: #5427.

[harvesterhci-io-github-bot]

Pre Ready-For-Testing Checklist

• If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
  The HEP PR is at:

• Where is the reproduce steps/test steps documented?
  The reproduce steps/test steps are at: There are two demos for reproduce and resolved in this PR enhancement: prohibit users from resizing volume when vm is stopping #5409, please check it to reproduce it.

• Is there a workaround for the issue? If so, where is it documented?
  The workaround is at:

• Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
  The PR is at:
  master-head: enhancement: prohibit users from resizing volume when vm is stopping #5409
  v1.2 backport: enhancement: prohibit users from resizing volume when vm is stopping (backport #5409) #5440
  v1.3 backport: enhancement: prohibit users from resizing volume when vm is stopping (backport #5409) #5441

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

• If labeled: area/ui Has the UI issue filed or ready to be merged?
  The UI issue/PR is at:

• If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
  The documentation/KB PR is at:

• If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

  • The automation skeleton PR is at:
  • The automation test case PR is at:

• If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
  The compatibility issue is filed at:

[harvesterhci-io-github-bot]

Automation e2e test issue: harvester/tests#1180

[albinsun]

Test PASS on harvester-v1.4.0-dev-20240830.

Environment

• harvester-v1.4.0-dev-20240830
  • Profile: 2 nodes QEMU/KVM (8C/16G/500G per node)
  • ui-source: Auto

Prerequisite

1. Fresh install harvester with any nodes

   

2. Create a VM, check Running.

   

Steps

1. VM => ⋮ => Edit Config, should NOT be able to resize. ✔️

   

2. Stop VM => ⋮ => Edit Config when Stopping, should NOT be able to resize. ✔️

   

3. Check VM Stopped => ⋮ => Edit Config, should be able to resize. ✔️

   • Resizing
     
   • Ready
     
4. Start VM, check Running and disk do resized. ✔️

   • VM Running
     
   • Volume do resized
     

Note

1. enhancement: prohibit users from resizing volume when vm is stopping #5409