[FEATURE] Enhance the import experience to Rancher

[yasker]

Currently user need to log into a Harvester physical node to run kubectl to import the Harvester cluster to a Rancher cluster.

We should allow that in the UI. Also, we need to enforce that one Harvester cluster can only be managed by one Rancher.

[jnfinitym]

I also noticed the binding script in Rancher 2.6.1 seems to look for k3s.yaml instead of rke2.yaml which is created in the installation of Harvester 0.3; copying /etc/rancher/rke2/rke2.yaml to /etc/rancher/k3s/k3s.yaml allowed me to add default as admin-role and subsequently join the Rancher. Should I file this in a dedicated issue or is this just part of this one?

[yasker]

@jnfinitym can you elaborate? Which binding script you're talking about? Might be another issue.

[jnfinitym]

I will file a seperate issue then, so I have mroe space to describe it - I am not home right now, so I will try it this weekend, so I can add the exact error messages I got and what exactly I did to get around them; I am specifically talking about importing Harvester to a Rancher instance, but it looks to be easily resolvable, but I am thinking it may actually be a Rancher Problem and not a Harvester Problem… My workaround was on the Harvester side though

[jnfinitym]

Weird, today I installed Harvester again from the same USB Stick and used the same version of Rancher deployed in the same way (in a VM on docker) and didn’t get the same issue!? - can’t reproduce it anymore, so I guess it was just a fluke.

…

On 13 Oct 2021, 22:27 +0200, Sheng Yang ***@***.***>, wrote: @jnfinitym can you elaborate? Which binding script you're talking about? Might be another issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[guangbochen]

Refer from #1437

Expected:

that explain how to import a Harvester cluster. E.g. the specific steps to be able to run the "kubectl" command in harvester.

Actual:

user is shown generic instructions to run the command on "an existing Kubernetes cluster running a supported Kubernetes version"

[gitlawr]

Proposal for the import UX:

1. In Rancher UI, we show the instructions for importing Harvester using Harvester UI.
   

2. In Harvester settings, add a cluster-registration-url settings. Users import the Harvester cluster by clicking the Import to Rancher button and inputing the registration URL.
   

3. Under the hood, Harvester settings controller applies the manifests for the import.

[guangbochen]

LGTM

[guangbochen]

To Test: (and please sync to close rancher/dashboard#4531 if passes)

1. Spin up the Rancher v2.6.3-rc1 and In Rancher UI, we show the instructions for importing Harvester using Harvester UI.
   

2. In Harvester settings, add a cluster-registration-url settings. Users import the Harvester cluster by clicking the Import to Rancher button and inputing the registration URL.
   

3. Under the hood, the Harvester settings controller applies the manifests for the import and the cluster will be visible in the Rancher UI.

please also close the issue of rancher/dashboard#4531 if the validation passes, thanks.

[TachunLin]

@gitlawr , @n313893254
Verified not fixed on master-81141c98-head with latest rancher v2.6-head. Move it to implement pipeline.
Please check whether the feature and UI have merged to the latest master release.

On Rancher v2.6-head, we can see the instructions for importing Harvester under registration tab

While we can't find the cluster-registration-url configuration in harvester settings page

[n313893254]

@TachunLin My bad. As the PR is merged by rancher/dashboard, we should validate cluster-registration-url after harvester/dashboard rebase rancher/dashboard.

[WuJun2016]

rebase, Done.

[TachunLin]

Verified fixed on master-b7e562d3-head with Rancher v2.6.3-rc1 .Close this issue.

Result

User can input registration url from rancher into harvester settings then import harvester in rancher dashboard

Test Information

• Test Environment: 1 nodes harvester on local kvm/qemu
• Harvester version: master-b7e562d3-head
• Rancher version: v2.6.3-rc1

Environment Preparation

1. Install harvester v2.6.3-rc1 in docker command
2. Update the ui-dashboard-index and ui-offline-preferred in rancher global settings

Verify Steps

1. Environment preparation as above steps
2. Access virtualization management page in rancher
3. Press ctrl+R to reload page
4. Import existing harvester
5. Copy the registration url
   
6. Access harvester dashboard settings
7. Edit the cluster-registration-url
   
8. Paste the registration url and save
   

9. Back to rancher dashboard and wait for import process
   

10. Access harvester from rancher virtualization management page