Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OgImage is optional but an og:image tag is undefined when not in use #10

Closed
skattabrain opened this issue Jan 18, 2023 · 2 comments
Closed

Comments

@skattabrain
Copy link

skattabrain commented Jan 18, 2023

Details

I got OgImageScreenshot working and it's great, trouble is generating the screenshots is too time and resource consuming so I'm planning to do without og:image for now.

If I remove the <OgImageScreenshot /> tag from my markup, the task doesn't run to generate the images, but it's creating an empty meta tag for twitter:card and og:image. Wouldn't it be better completely omitted?

...
<meta property="twitter:card" content="summary_large_image">
...
<meta property="og:image">
...

This is a great plugin BTW, I'm hoping it will continue to be maintained, it's a major time and BS saver!

@harlan-zw
Copy link
Owner

Hey @skattabrain, thanks! And thanks for the issue

I've pushed up a fix for this and it's available in 0.4.14.

I'll be pushing up v1 of nuxt-og-image very soon which adds satori support which should address the time/resource issue. This will be maintained as it's powering a bunch of my sites now :)

@skattabrain
Copy link
Author

Fantastic! Looking forward to that performance boost!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants