Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Provider Executor Plugins #11

Open
RossMurr4y opened this issue Mar 24, 2020 · 0 comments
Open

Feature - Provider Executor Plugins #11

RossMurr4y opened this issue Mar 24, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@RossMurr4y
Copy link
Contributor

Expected Behavior

The executor should source utility scripts such as automation/utility.sh from the current provider within the executor plugins directory as well as the currently sourced shared provider scripts.

Current Behavior

Currently, the script automation/common.sh is dot-sourced at the top of most bash scripts in order to provider common functions. Within common.sh, other scripts such as automation/utility.sh are subsequently dot-sourced, providing further functionality and environment variable exports. These are essential for the original scripts to function and have access to the appropriate content.

This behaviour does not currently support provider-specific content without merging it into the shared provider.

Possible Solution

Option 1

If within automation/common.sh a lookup is performed for plugins matching the current provider, both the shared and provider utility scripts could be dot-sourced.

Both AWS and Azure would require a new repository to host executor plugin content .

Option 2

The lookup is performed on the engine plugin directory, seeking the same file. This is less desirable as it does not maintain a separation between engine/executor however it does mean plugin developers only have the one code repository to develop.

Context

Provider-specific utility functions currently must be merged with the shared provider, which poses a blocker for non-official plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant