Add encoding support #550
Merged
Add encoding support #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompatability on Windows (see e.g. r-lib/devtools#1306)
…ompatability on Windows (see e.g. r-lib/devtools#1306) Add NEWS.md line about the change.
Remove ... from call/definition of test_files
|
Do you think you could come up with a simple test too? |
|
@hadley: The simplest test I can think of is to create a dummy package in |
|
Maybe test one level up? (i.e. |
|
@hadley: Added simple test for Latin-1 and UTF-8. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with proper recoding of file read by
readLines()call. @hadley: PTAL.Closes #518 (=includes it).
CC @hansharhoff.