Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE Design System Components: Update Buttons according to M3 #619

Open
5 of 9 tasks
mklmrgn opened this issue Sep 4, 2024 · 15 comments
Open
5 of 9 tasks

TWE Design System Components: Update Buttons according to M3 #619

mklmrgn opened this issue Sep 4, 2024 · 15 comments

Comments

@mklmrgn
Copy link
Member

mklmrgn commented Sep 4, 2024

Overview

Change the Button Components to a more modern style based on Material Design 3.

Action Items

  • Research button styling for Google's M3
  • Update Component Design
  • Delete extraneous variant states (ie enabled vs active)
  • Create buttons with icons
  • Communicate changes in issue's comments and with design team
  • Get sign-off from Project Manager
  • Update Component Library and Microsite
  • Close Issue
  • Release Dependency on TWE Design System Components: Dialogs (Modals/Pop-ups) #409 and if it is the last dependency to get released, move issue to the new issue approval column & add the ready for design lead label

Resources/Instructions

Use Material Design (https://m3.material.io/) as guideline

@KC-skc
Copy link
Member

KC-skc commented Sep 19, 2024

@muntiCloud Please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

@mklmrgn mklmrgn assigned JaimeCucalon and unassigned muntiCloud and mklmrgn Sep 24, 2024
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: TWE: Project Board Sep 26, 2024
@mklmrgn mklmrgn moved this from New Issue Approval to In progress (actively working) in P: TWE: Project Board Sep 26, 2024
@mklmrgn mklmrgn added size: 3pt Can be done in 13-18 hours complexity: medium PBV: design all issues for the design team and removed complexity: small labels Sep 26, 2024
@JaimeCucalon
Copy link
Member

This week I researched the M3 styling and approach. I learned that they have quite an extensive level of buttons and CTA elements that determine hierarchy for call to action. I'm wondering if we can narrow down the level of buttons before getting started. And focused on the common buttons.
Screenshot 2024-09-26 at 12 49 00 PM
vs
lvlz8hsu-1

I also studied the existing button master for the internship team. I believe it's minimal but not flexible enough. I would love to the discuss the complexity of buttons we want to keep for the project without adding too much work for future updates.

@JaimeCucalon
Copy link
Member

JaimeCucalon commented Oct 10, 2024

  1. Progress:
  • Created 4 style of buttons following MD3 Specs and guidelines-Filled, outlined, text, and tonal.
  • Created icon variants for all 4 with boolean properties
  1. Blockers:
  • Researching if the pressed state is needed for our design system. It is very similar to the focused state, main difference is that it uses a ripple animation. Need to check with dev team to confirm feasibility.
  • Waiting on updated styles for icons, text, and button
  • Need to add icon variants to the design system. Color variants, and size variants
  1. Availability - 4 hours

  2. ETA: Hoping to have this component ready by end of next week

Screenshot 2024-10-10 at 10 14 14 AM https://www.figma.com/design/TTRS2FWXsrymHYpPJL1IdH/Internship-Team-Main-file?node-id=6474-7596&t=dsy9ee4753S2UBxn-4

@JaimeCucalon
Copy link
Member

JaimeCucalon commented Oct 17, 2024

Progress:
Matched elevation, text size, icon size, and padding to MD3 design. There is one small icon/padding detail missing that needs addressing.

Blockers:
Researching the use of different size buttons by MD3. So far research shows that common buttons use only one size. The FAB buttons are the only button components on the system that include 3 sizes, small, regular, and large -
https://m3.material.io/components/floating-action-button/overview

Availability - 4 hours

ETA: Need another week.
Screenshot 2024-10-17 at 10 04 54 AM

https://www.figma.com/design/TTRS2FWXsrymHYpPJL1IdH/Internship-Team-Main-file?node-id=6474-7596&t=dsy9ee4753S2UBxn-4

@JaimeCucalon
Copy link
Member

JaimeCucalon commented Oct 24, 2024

Progress:

  • Revised all the color applications based on new color styles and state layers from Michael
  • Set up the icon property to be swappable without changing color. Relabelled all icons in the library to fix this minor glitch
Screenshot 2024-10-24 at 9 41 39 AM

Blockers:

  • Need to confirm the color application is correct before creating different size buttons

Availability - 4 hours

ETA: Next Tuesday

@JaimeCucalon
Copy link
Member

Made some additional changes to the button component colors in order to pass the color contrast requirements.
The page includes two versions

  • Version on the left follows the MD3 styling 100% but fails the color contrast. Each one of the button states shows the color contrast ratings
  • Version on the right has two slight changes to the MD3 styling but it passes color contrast. More details in the figma file for changes made.
  • The only button states that don't pass the color contrast standards is the disabled state. This is also true for the MD3 design system button component

@mklmrgn - Ready for review
Screenshot 2024-10-24 at 12 04 41 PM

@JaimeCucalon
Copy link
Member

Progress:

  • Worked on the color contrast of all buttons and states. Discussed with Michael changes required to the color system in order to pass color contrast requirements.
Screenshot 2024-10-31 at 9 48 23 AM

Blockers:
Need to determine if our color system requires different size buttons to create hierarchy for calls to action on the site. The new button system has 4 type of buttons; Filled, Outline, Tonal, and Text. This follows the MD3 system.
Screenshot 2024-10-31 at 9 47 10 AM

vs the current design system on the site that has 3 sizes, and doesn't follow the MD3 system closely.
Screenshot 2024-10-31 at 9 40 43 AM

@JaimeCucalon
Copy link
Member

Notes from TWE on Button sizes:
The discussion with Bonnie and Michael revealed that we have different button sizes because it follows the HFLA design system. That system showed that there are some large spaces where the primary call to action needs to be larger in order to fill the space for hero banners.

We decided to look into different sizes for the primary button only. Since that will be the button that gets featured the most. The secondary and tertiary button types will only have one size.

Here are the examples we reviewed that showed how both HFLA and MD3 use a similar approach.
Screenshot 2024-10-31 at 10 32 54 AM
Screenshot 2024-10-31 at 10 24 29 AM

@ExperimentsInHonesty

This comment was marked as resolved.

@JaimeCucalon
Copy link
Member

Progress:
Reviewed the Hack for LA design system and website. From those learnings, I added an extra large button size to the Primary Button Component. This should suffice large hero banner spaces.

Also, broke up the button into two separate components, Primary Button and Secondary Button with respective variants.
Screenshot 2024-11-14 at 9 30 46 AM

Blockers
Waiting on approval to make these the final edits to the button sizes and variants. Also, need to update the color stylings based on recent changes from Mike.

Availability
4 hours

ETA
Expected to complete it by end of November latest.

https://www.figma.com/design/TTRS2FWXsrymHYpPJL1IdH/Internship-Team-Main-file?node-id=6474-7596&t=dsy9ee4753S2UBxn-4

@ExperimentsInHonesty
Copy link
Member

@mklmrgn This issue is ready for your review. Jaime mentioned the following in the comment above

Waiting on approval to make these the final edits to the button sizes and variants. Also, need to update the color stylings based on recent changes from Mike.

@JaimeCucalon
Copy link
Member

Progress:
Received approval for the sizes and color styling for the button variants. And combined the primary and secondary button variants into one component.

Next step is to create guidelines, and web page specs frame.

Blockers:
None

ETA:
Expected to complete by next week.
Screenshot 2024-11-21 at 9 43 43 AM

@mklmrgn
Copy link
Member Author

mklmrgn commented Jan 23, 2025

Progress:
Updated specs and replaced old components on Design System (WIP) Figma Page

Image

Next step is to update microsite with changes

Blockers:
None

ETA:
Expected to complete by next week.

@mklmrgn
Copy link
Member Author

mklmrgn commented Jan 30, 2025

Progress:
Updated microsite with updated components - Component and microsite are complete

Image

Blockers:
None

@mklmrgn mklmrgn moved this from In progress (actively working) to Questions/Review in P: TWE: Project Board Jan 30, 2025
@mklmrgn
Copy link
Member Author

mklmrgn commented Jan 30, 2025

@joshfishman This is ready for Dev Lead sign off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Questions/Review
Development

No branches or pull requests

6 participants