fix(package.json): remove unnecessary files in published package #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for h6s-react-examples failed.
|
✅ Deploy Preview for storybook-h6s ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for h6s-dev canceled.
|
SoYoung210
approved these changes
Dec 12, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
# [@h6s/calendar-v1.0.7-alpha.1](https://github.com/h6s-dev/h6s/compare/@h6s/calendar-v1.0.6...@h6s/calendar-v1.0.7-alpha.1) (2022-12-13) ### Bug Fixes * **package.json:** remove unnecessary files in published package ([#227](#227)) ([fb0f783](fb0f783))
|
🎉 This PR is included in version @h6s/calendar-v1.0.7-alpha.1 🎉 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
# [@h6s/table-v1.0.4-alpha.1](https://github.com/h6s-dev/h6s/compare/@h6s/table-v1.0.3...@h6s/table-v1.0.4-alpha.1) (2022-12-13) ### Bug Fixes * **@h6s/table:** trigger release ([93d6b04](93d6b04)) * **package.json:** remove unnecessary files in published package ([#227](#227)) ([fb0f783](fb0f783))
|
🎉 This PR is included in version @h6s/table-v1.0.4-alpha.1 🎉 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
# [@h6s/calendar-v1.0.7](https://github.com/h6s-dev/h6s/compare/@h6s/calendar-v1.0.6...@h6s/calendar-v1.0.7) (2022-12-20) ### Bug Fixes * **package.json:** remove unnecessary files in published package ([#227](#227)) ([fb0f783](fb0f783))
|
🎉 This PR is included in version @h6s/calendar-v1.0.7 🎉 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
# [@h6s/table-v1.0.4](https://github.com/h6s-dev/h6s/compare/@h6s/table-v1.0.3...@h6s/table-v1.0.4) (2022-12-20) ### Bug Fixes * **package.json:** remove unnecessary files in published package ([#227](#227)) ([fb0f783](fb0f783))
|
🎉 This PR is included in version @h6s/table-v1.0.4 🎉 |
|
@JaeYeopHan @SoYoung210 Could you add me in https://github.com/h6s-dev/h6s#contributors- as bug(🐛)? I thought this PR can be bug. but If you think this PR is another emoji key, It is also good for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is unnecessary files in user of this packages(@h6s/table, @h6s/calendar)
You can see unnecessary files(tsconfig.json, playwright.config.ts, src, .e2e) if install this packages.
Solution: How about using files field of package.json.
I used files filed as ["dist", "esm"], but we don't have to worry about ignoring necessary files like package.json, README, LICENSE that almost be used as filename in @h6s/table, @h6s/calendar. because below filename will be contained in package defaultly.
Certain files are always included, regardless of settings:
package.json have to narrow files to publish package contain only necessary. by using files field, we can narrow package's files. so I added files field
{ "files": [ "dist", "esm" ], }