-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including google analytics without GDPR info #2242
Comments
We've discussed it previously and my mind hasn't really changed about including GA. As for your suggestions to improve this, we're not going to ship commented out code and/or inline documentation. If you want to propose some further documentation to explain the issues around GDPR then I'd be happy to see that. |
Personally, I didn't check documentation in years ( not that much in HTML is changing ), however, I often use repo. There are other inline comments like |
We keep the documentation up to date since the project touches on many subjects. The documentation is the place for discussion of GDPR. There is no way we can explain GDPR in a ten word sentence. There are three comments in the HTML. One is legacy (the favicon.ico comment, which is probably a candidate for removal) and then a comment about where to put your site and then the single instruction "Google Analytics: change UA-XXXXX-Y to be your site's ID," which itself is also a candidate for removal. We used to have much more complicated documentation inline, in the source code and have since moved away from that. I'm not interested in starting that back up again. We can and do educate, we just don't do it in the source code. |
Yeah, I meant more to include a link to somewhere. Definitely not a thing for a one-liner. OK. That explanation makes sense. I've read through the old stuff about analytics and although I don't agree I understand why you keep that. |
I'm looking for ways to be useful to the community. Can I take this issue and put a paragraph or two about Google Analytics and GDPR in the documentation? |
@isaac-friedman Yes 👍 |
closed with #2262 |
I'm submitting a ...
I noticed that html5 boilerplate is still including google analytics by default. Personally I wouldn't really try to promote it here as it's not really considered a good set of practice ( although often required ). However, in GDPR times using it without information can actually get you in troubles.
Possible solutions:
Happy to send PR if you have recommended way to go.
The text was updated successfully, but these errors were encountered: