From e88103bb4407c650fb98addef8f904db9591455a Mon Sep 17 00:00:00 2001 From: TJ Silver Date: Tue, 12 Nov 2019 12:25:54 +0000 Subject: [PATCH] remove variants 1 and 3 --- .../assets/helpers/abTests/abtestDefinitions.js | 8 +------- .../contributions-landing/components/ContributionForm.jsx | 8 +------- .../pages/contributions-landing/contributionsLanding.jsx | 3 +-- 3 files changed, 3 insertions(+), 16 deletions(-) diff --git a/support-frontend/assets/helpers/abTests/abtestDefinitions.js b/support-frontend/assets/helpers/abTests/abtestDefinitions.js index 975abf39c5..8d640affbd 100644 --- a/support-frontend/assets/helpers/abTests/abtestDefinitions.js +++ b/support-frontend/assets/helpers/abTests/abtestDefinitions.js @@ -9,8 +9,8 @@ import { // ----- Tests ----- // export type LandingPageCopyReturningSinglesTestVariants = 'control' | 'returningSingle' | 'notintest'; export type LandingPageStripeElementsRecurringTestVariants = 'control' | 'stripeElements' | 'notintest'; -export type PaymentSecurityDesignTestVariants = 'control' | 'V1_securetop' | 'V2_securemiddle' | 'V3_securebottom' | 'V4_grey' | 'notintest' export type RecurringStripePaymentRequestButtonTestVariants = 'contro' | 'paymentRequestButton' | 'notintest'; +export type PaymentSecurityDesignTestVariants = 'control' | 'V2_securemiddle' | 'V4_grey' | 'notintest'; const contributionsLandingPageMatch = '/(uk|us|eu|au|ca|nz|int)/contribute(/.*)?$'; @@ -89,15 +89,9 @@ export const tests: Tests = { { id: 'control', }, - { - id: 'V1_securetop', - }, { id: 'V2_securemiddle', }, - { - id: 'V3_securebottom', - }, { id: 'V4_grey', }, diff --git a/support-frontend/assets/pages/contributions-landing/components/ContributionForm.jsx b/support-frontend/assets/pages/contributions-landing/components/ContributionForm.jsx index ae61f23747..eca758ccce 100644 --- a/support-frontend/assets/pages/contributions-landing/components/ContributionForm.jsx +++ b/support-frontend/assets/pages/contributions-landing/components/ContributionForm.jsx @@ -52,10 +52,9 @@ import type { PaymentMethod } from 'helpers/paymentMethods'; import { DirectDebit, Stripe, ExistingCard, ExistingDirectDebit } from 'helpers/paymentMethods'; import { getCampaignName } from 'helpers/campaigns'; import type { LandingPageStripeElementsRecurringTestVariants } from 'helpers/abTests/abtestDefinitions'; - -import SecureTransactionIndicator from 'components/secureTransactionIndicator/secureTransactionIndicator'; import type { PaymentSecurityDesignTestVariants, RecurringStripePaymentRequestButtonTestVariants } from 'helpers/abTests/abtestDefinitions'; + // ----- Types ----- // /* eslint-disable react/no-unused-prop-types */ type PropTypes = {| @@ -250,8 +249,6 @@ function withProps(props: PropTypes) { const showSecureStripeContainer: boolean = props.paymentSecurityDesignTestVariant !== 'control' || props.countryGroupId === 'GBPCountries'; const showSecureButtonBg: boolean = showSecureStripeContainer && props.paymentMethod === Stripe && (props.stripeElementsRecurringTestVariant === 'stripeElements' || props.contributionType === 'ONE_OFF'); - const showSecureTransactionIndicator: boolean = props.paymentSecurityDesignTestVariant === 'V3_securebottom' && props.countryGroupId !== 'GBPCountries'; - const secureTransactionIndicatorClassNames: string[] = showSecureButtonBg ? ['bottom-grey'] : ['bottom-regular']; return (
@@ -294,9 +291,6 @@ function withProps(props: PropTypes) { onPaymentAuthorisation={props.onPaymentAuthorisation} showSecureBackground={showSecureButtonBg} /> - {showSecureTransactionIndicator && - - } : null; +const showSecureTransactionIndicator = countryGroupId === 'GBPCountries' ? : null; function contributionsLandingPage(campaignCodeParameter: ?string) { return (