Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka reports facebook in-app browser as an illegal user agent #213

Closed
michaelwmcnamara opened this issue Sep 8, 2017 · 3 comments
Closed

Comments

@michaelwmcnamara
Copy link
Contributor

michaelwmcnamara commented Sep 8, 2017

Sample log:

2017-07-22 17:22:31,719 [application-akka.actor.default-dispatcher-19059] WARN akka.actor.ActorSystemImpl - Illegal header: Illegal 'user-agent' header: Invalid input '[', expected 'EOI', product-or-comment, WSP, comment or CRLF (line 1, column 111): Mozilla/5.0 (iPhone; CPU iPhone OS 10_3_2 like Mac OS X) AppleWebKit/603.2.4 (KHTML, like Gecko) Mobile/14F89 [FBAN/FBIOS;FBAV/133.0.0.51.89;FBBV/65438308;FBDV/iPhone6,2;FBMD/iPhone;FBSN/iOS;FBSV/10.3.2;FBSS/2;FBCR/EE;FBID/phone;FBLC/en_GB;FBOP/5;FBRV/0]

useful reference: https://stackoverflow.com/questions/11414006/is-this-a-facebook-for-ios-webview-user-agent

@michaelwmcnamara michaelwmcnamara changed the title user agent reports facebook in-app browser as an illegal user agent Akka reports facebook in-app browser as an illegal user agent Sep 8, 2017
@davidfurey
Copy link
Member

The facebook user-agent does not comply with the RFC. This log is just a warning, the request is still processed correctly. I'm not sure that we can do anything until akka/akka-http#687 is resolved.

@michaelwmcnamara
Copy link
Contributor Author

michaelwmcnamara commented Jul 24, 2018

Reopening this as it looks like Akka introduced the ability to disable warnings for certain headers on 7th May 2018. Presumably this will mean updating the version we use and also creating a list of specific headers to ignore. Will look into doing this and update as I go.

@michaelwmcnamara
Copy link
Contributor Author

This is now resolved.
A later version of Play incorporated some Akka fixes that resolved this.
We have updated to the latest version of Play 2.6.16 and issue no longer occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants