Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use IsA for fundamental types #1069

Closed
bilelmoussaoui opened this issue Mar 14, 2021 · 1 comment · Fixed by #1294
Closed

Don't use IsA for fundamental types #1069

bilelmoussaoui opened this issue Mar 14, 2021 · 1 comment · Fixed by #1294
Labels
enhancement

Comments

@bilelmoussaoui
Copy link
Member

Currently gir, uses IsA for generated code for any fundamental type. What would be nice is to have gir know the difference and only use IsA for objects.
@bilelmoussaoui bilelmoussaoui mentioned this issue Mar 14, 2021
Merged
@sdroege sdroege changed the title Don't use IsA for fundemental types Don't use IsA for fundamental types Mar 14, 2021
@bilelmoussaoui
Copy link
Member Author

Maybe instead it should use AsRef<A> ?

@bilelmoussaoui bilelmoussaoui mentioned this issue Nov 28, 2021
Closed
@bilelmoussaoui bilelmoussaoui mentioned this issue Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support fundamental types
1 participant
@bilelmoussaoui