Skip to content

Commit aa5b543

Browse files
committed
filebrowser:sort: use compareToIgnoreCase for name comparision
1 parent 7e680df commit aa5b543

File tree

3 files changed

+3
-20
lines changed

3 files changed

+3
-20
lines changed

app/src/main/java/net/gsantner/markor/ui/FilesystemViewerCreator.java

-13
Original file line numberDiff line numberDiff line change
@@ -54,19 +54,6 @@ public static FilesystemViewerData.Options prepareFsViewerOpts(Context context,
5454
opts.contentDescriptionSelected = R.string.selected;
5555
opts.contentDescriptionFile = R.string.file;
5656

57-
opts.fileComparable = (o1, o2) -> {
58-
String m1 = ContextUtils.get().getMimeType(o1);
59-
String m2 = ContextUtils.get().getMimeType(o2);
60-
if (m1.startsWith("text/") || m2.startsWith("text")) {
61-
if (m1.startsWith("text/") && !m2.startsWith("text/")) {
62-
return -1;
63-
} else if (m2.startsWith("text/") && !m1.startsWith("text/")) {
64-
return 1;
65-
}
66-
}
67-
return 0;
68-
};
69-
7057
opts.accentColor = R.color.accent;
7158
opts.primaryColor = R.color.primary;
7259
opts.primaryTextColor = darkTheme ? R.color.dark__primary_text : R.color.light__primary_text;

app/src/main/java/net/gsantner/opoc/ui/FilesystemViewerAdapter.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -595,7 +595,7 @@ public int compare(File o1, File o2) {
595595
return 0;
596596
}
597597
if (o1.isDirectory() && _dopt.folderFirst)
598-
return o2.isDirectory() ? o1.getName().toLowerCase(Locale.getDefault()).compareTo(o2.getName().toLowerCase(Locale.getDefault())) : -1;
598+
return o2.isDirectory() ? o1.getName().compareToIgnoreCase(o2.getName()) : -1;
599599
else if (!canWrite(o2))
600600
return -1;
601601
else if (o2.isDirectory() && _dopt.folderFirst)
@@ -606,7 +606,7 @@ else if (_dopt.fileComparable != null) {
606606
return v;
607607
}
608608
}
609-
return o1.getName().toLowerCase(Locale.getDefault()).compareTo(o2.getName().toLowerCase(Locale.getDefault()));
609+
return o1.getName().compareToIgnoreCase(o2.getName());
610610
}
611611

612612
public boolean isCurrentFolderHome() {

app/src/main/java/net/gsantner/opoc/ui/FilesystemViewerFragment.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -544,14 +544,10 @@ public static Comparator<File> sortFolder(List<File> filesToSort) {
544544

545545
switch (sortMethod) {
546546
case SORT_BY_NAME:
547-
return new File(current.getAbsolutePath().toLowerCase()).compareTo(
548-
new File(other.getAbsolutePath().toLowerCase()));
547+
return current.getName().compareToIgnoreCase(other.getName());
549548
case SORT_BY_DATE:
550549
return Long.compare(other.lastModified(), current.lastModified());
551550
case SORT_BY_FILESIZE:
552-
if (current.isDirectory() && other.isDirectory()) {
553-
return other.list().length - current.list().length;
554-
}
555551
return Long.compare(other.length(), current.length());
556552
}
557553
return current.compareTo(other);

0 commit comments

Comments
 (0)