Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: use previously acked version when requesting resources after stream failure #5351

Closed
easwars opened this issue May 13, 2022 · 1 comment · Fixed by #5422
Closed

xds: use previously acked version when requesting resources after stream failure #5351

easwars opened this issue May 13, 2022 · 1 comment · Fixed by #5422
Assignees

Comments

@easwars
Copy link
Contributor

easwars commented May 13, 2022

Expected behavior

xDS spec says the following:

Note that the version for a resource type is not a property of an individual xDS stream but rather a property of the resources themselves. If the stream becomes broken and the client creates a new stream, the client’s initial request on the new stream should indicate the most recent version seen by the client on the previous stream

Current behavior

grpc-go implementation, as part of handing stream failure and resending requests for existing subscriptions, explicitly clears the version and nonce maps. This leads to and sending out the new requests with empty version.

@easwars easwars changed the title xds: use previously acked version when requesting cached resources after stream failure xds: use previously acked version when requesting resources after stream failure May 13, 2022
@easwars
Copy link
Contributor Author

easwars commented May 13, 2022

Looks like this has been the behavior from day 1: #3227

@easwars easwars self-assigned this May 16, 2022
@zasweq zasweq added the P1 label May 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants