From 9871e09f09c8d9ea3619b635aec2c9c786e86aa8 Mon Sep 17 00:00:00 2001 From: Tamir Duberstein Date: Mon, 19 Dec 2016 15:48:27 -0500 Subject: [PATCH] Use codes.Code.String() rather than logging integers This produces better human-readable error messages. --- rpc_util.go | 2 +- transport/handler_server_test.go | 2 +- transport/transport.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rpc_util.go b/rpc_util.go index d98a88376b95..73c3a96655d3 100644 --- a/rpc_util.go +++ b/rpc_util.go @@ -377,7 +377,7 @@ type rpcError struct { } func (e *rpcError) Error() string { - return fmt.Sprintf("rpc error: code = %d desc = %s", e.code, e.desc) + return fmt.Sprintf("rpc error: code = %s desc = %s", e.code, e.desc) } // Code returns the error code for err if it was produced by the rpc system. diff --git a/transport/handler_server_test.go b/transport/handler_server_test.go index 9843d36b61f8..44adf2eed86c 100644 --- a/transport/handler_server_test.go +++ b/transport/handler_server_test.go @@ -188,7 +188,7 @@ func TestHandlerTransport_NewServerHandlerTransport(t *testing.T) { }, RequestURI: "/service/foo.bar", }, - wantErr: `stream error: code = 13 desc = "malformed time-out: transport: timeout unit is not recognized: \"tomorrow\""`, + wantErr: `stream error: code = Internal desc = "malformed time-out: transport: timeout unit is not recognized: \"tomorrow\""`, }, { name: "with metadata", diff --git a/transport/transport.go b/transport/transport.go index caee54a80176..7a462ecd383c 100644 --- a/transport/transport.go +++ b/transport/transport.go @@ -568,7 +568,7 @@ type StreamError struct { } func (e StreamError) Error() string { - return fmt.Sprintf("stream error: code = %d desc = %q", e.Code, e.Desc) + return fmt.Sprintf("stream error: code = %s desc = %q", e.Code, e.Desc) } // ContextErr converts the error from context package into a StreamError.