Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages should be specified at the Grommet level instead of the component level #44

Open
jcfilben opened this issue Jun 1, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jcfilben
Copy link
Collaborator

jcfilben commented Jun 1, 2023

Please describe what the rule should do:
If the messages prop is used at the individual component level, advise users to switch to using the messages prop at the Grommet level instead.
What category of rule is this? (place an "X" next to just one item)

[ ] Warns about a potential error (problem)
[x] Suggests an alternate way of doing something (suggestion)
[ ] Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

<Button messages={...} />

Why should this rule be included in eslint-plugin-grommet?
In Grommet we want the general direction for messages to move away from specifying them at the component level and instead specify messages for the entire application at the Grommet wrapper level.

@jcfilben jcfilben added the enhancement New feature or request label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant