Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Current Block Number To the Main Tab in a Graphical Way #841

Closed
RoboticMind opened this issue Jan 17, 2018 · 11 comments · Fixed by #2394
Closed

Add Current Block Number To the Main Tab in a Graphical Way #841

RoboticMind opened this issue Jan 17, 2018 · 11 comments · Fixed by #2394
Assignees
Milestone

Comments

@RoboticMind
Copy link
Contributor

RoboticMind commented Jan 17, 2018

This could be done either only when syncing or in at all times

Here's the way Curecoin does that:
untitled
A more zoomed in view:
untitled

We could do something similar

This would help new users know that

  1. the wallet is syncing by itself
  2. the progress of that syncing
@RoboticMind RoboticMind changed the title Add Current Block Number To the Main Tab Add Current Block Number To the Main Tab in a Graphical Way Jan 17, 2018
@tomasbrod
Copy link
Member

Current block number IS already displayed on the main (Overview) tab.
Voting to close.

@RoboticMind
Copy link
Contributor Author

RoboticMind commented Jan 18, 2018

What I meant by that is display a more clear indicator of:

the current block and how far it is behind the network
and to do this in a graph or something immediately clear to the user

The current way it is displayed doesn't tell users how far it is in syncing and is harder to find

@iFoggz
Copy link
Member

iFoggz commented Jan 19, 2018

what will determine the top block on the network. to be honest u can say that a certain node is correct height or not and just go for it.

@RoboticMind
Copy link
Contributor Author

RoboticMind commented Jan 19, 2018

There already is an estimated total blocks number in the debug menu. why not use that? It seems to be accurate enough.

@RoboticMind
Copy link
Contributor Author

Here's where I believe the estimate is created:
https://github.com/gridcoin/Gridcoin-Research/blob/development/src/checkpoints.cpp#L72

@RoboticMind RoboticMind mentioned this issue May 25, 2018
2 tasks
@ethanteng
Copy link

Has anyone picked this up, or is this confirmed to be part of the larger GUI update? If not, I was thinking of taking a crack at it.

@jamescowens
Copy link
Member

I don't think the GUI update specifically framed this out. Make sure you do this off of the dev branch. Many many changes compared to the master branch.

@jamescowens
Copy link
Member

We should do this as part of the Bitcoin code rebase, since the necessary primitives are there to support this.

@cyrossignol
Copy link
Member

Yep.

@jamescowens
Copy link
Member

jamescowens commented Nov 28, 2021

I did a poor man's version of this in #2394 for Janice, which simply enhances the OverviewPage::setHeight function. I think this is good enough to close this specific issue. We can do fancier progress bar stuff when we port over more of Bitcoin's code.

@jamescowens jamescowens added this to the Janice milestone Nov 28, 2021
@jamescowens jamescowens self-assigned this Nov 28, 2021
@RoboticMind
Copy link
Contributor Author

Yeah, I think that addresses my main concerns. I think a little progress bar might be nice as well, but I'd be fine with closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants