Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"background" option in sections maybe not working? #295

Closed
1 task done
Llannelongue opened this issue Jan 3, 2025 · 2 comments · Fixed by #297 or stajichlab/stajichlab.github.io#4
Closed
1 task done
Labels
bug Something isn't working

Comments

@Llannelongue
Copy link

Checks

Link to your website repo

NA

Version of Lab Website Template you are using

1.3.1

Description

Hi, I may be missing something, but I haven't managed to make the "background" option work in a section.

i.e. trying {% include section.html background="images/some-bg-image.jpg" %} gives a similar result to {% include section.html %}

Looking at the testbed (screenshot below), it doesn't seem to work there either? But I may well missing something :)

Thanks!

image
@vincerubinetti
Copy link
Collaborator

This is a regression from v1.3.0, thanks for noticing. See this comment: https://github.com/greenelab/lab-website-template/pull/274/files#r1902049275

@vincerubinetti vincerubinetti added the bug Something isn't working label Jan 3, 2025
@vincerubinetti vincerubinetti mentioned this issue Jan 6, 2025
3 tasks
@vincerubinetti
Copy link
Collaborator

To be fixed by v1.3.2: #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants