-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix Linux: Different kill mechanism #115
Conversation
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: Total cost of whole PR so far: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: Total cost of whole PR so far: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: Total cost of whole PR so far: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: Total cost of whole PR so far: |
Eco-CI Output:
🌳 CO2 Data: Total cost of whole PR so far: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
We have seen runs having multiple kW which was due to truncation in the output of the CPU utilization stream

https://github.com/green-coding-solutions/argopy/actions/runs/13259456675
This hotfix kills the process more gracefully and thus truncation should not occur.
Greptile Summary
This PR modifies the process termination mechanism in
setup.sh
to address an issue where truncated CPU utilization data was causing incorrect energy measurements in the kWh range.kill_tree
function withpkill -SIGTERM
for Linux CPU monitoring terminationkill_tree
function for macOS process termination