From 6a369e9862bda1a5d89133619e88dbb2621238b2 Mon Sep 17 00:00:00 2001 From: Bill Dirks Date: Fri, 10 Jan 2025 10:36:21 -0800 Subject: [PATCH 1/2] Add MINORBUMP title tag. --- .github/pull_request_template.md | 2 +- .github/workflows/pr-title-checker.yml | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 606a48b360b6..18a4e20672bd 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,7 @@ - [ ] Description of PR changes above includes a link to [an existing GitHub issue](https://github.com/great-expectations/great_expectations/issues) -- [ ] PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB] +- [ ] PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB], [MINORBUMP] - [ ] Code is linted - run `invoke lint` (uses `ruff format` + `ruff check`) - [ ] Appropriate tests and docs have been updated diff --git a/.github/workflows/pr-title-checker.yml b/.github/workflows/pr-title-checker.yml index 06c4405a769a..b8f88cc04d26 100644 --- a/.github/workflows/pr-title-checker.yml +++ b/.github/workflows/pr-title-checker.yml @@ -14,9 +14,16 @@ jobs: runs-on: ubuntu-latest steps: - name: Check PR title validity - if: "!contains(github.event.pull_request.title, '[FEATURE]') && !contains(github.event.pull_request.title, '[BUGFIX]') && !contains(github.event.pull_request.title, '[DOCS]') && !contains(github.event.pull_request.title, '[MAINTENANCE]') && !contains(github.event.pull_request.title, '[CONTRIB]') && !contains(github.event.pull_request.title, '[RELEASE]')" + if: >- + !contains(github.event.pull_request.title, '[FEATURE]') && + !contains(github.event.pull_request.title, '[BUGFIX]') && + !contains(github.event.pull_request.title, '[DOCS]') && + !contains(github.event.pull_request.title, '[MAINTENANCE]') && + !contains(github.event.pull_request.title, '[CONTRIB]') && + !contains(github.event.pull_request.title, '[MINORBUMP]') && + !contains(github.event.pull_request.title, '[RELEASE]')" run: | - echo "Invalid PR title - please prefix with one of: [FEATURE] | [BUGFIX] | [DOCS] | [MAINTENANCE] | [CONTRIB] | [RELEASE]" + echo "Invalid PR title - please prefix with one of: [FEATURE] | [BUGFIX] | [DOCS] | [MAINTENANCE] | [CONTRIB] | [MINORBUMP] | [RELEASE]" exit 1 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 601274f145f53aa0e1e219f00543b09077a99ad3 Mon Sep 17 00:00:00 2001 From: Bill Dirks Date: Fri, 10 Jan 2025 10:38:56 -0800 Subject: [PATCH 2/2] Remove errant double quote. --- .github/workflows/pr-title-checker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-title-checker.yml b/.github/workflows/pr-title-checker.yml index b8f88cc04d26..b4f446339be2 100644 --- a/.github/workflows/pr-title-checker.yml +++ b/.github/workflows/pr-title-checker.yml @@ -21,7 +21,7 @@ jobs: !contains(github.event.pull_request.title, '[MAINTENANCE]') && !contains(github.event.pull_request.title, '[CONTRIB]') && !contains(github.event.pull_request.title, '[MINORBUMP]') && - !contains(github.event.pull_request.title, '[RELEASE]')" + !contains(github.event.pull_request.title, '[RELEASE]') run: | echo "Invalid PR title - please prefix with one of: [FEATURE] | [BUGFIX] | [DOCS] | [MAINTENANCE] | [CONTRIB] | [MINORBUMP] | [RELEASE]" exit 1