Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught exception on missing SQLAlchemy dialect #4243

Closed
RoyalTS opened this issue Feb 21, 2022 · 5 comments
Closed

Uncaught exception on missing SQLAlchemy dialect #4243

RoyalTS opened this issue Feb 21, 2022 · 5 comments
Labels
bug Bugs bugs bugs! community stale Stale issues and PRs

Comments

@RoyalTS
Copy link
Contributor

RoyalTS commented Feb 21, 2022

Describe the bug
Upon trying to set up a new expectations suite for a Snowflake table I get an uncaught exception

To Reproduce
Steps to reproduce the behavior:

  1. Run great_expectations --v3-api suite new --interactive --profile
  2. run the cell
profiler = UserConfigurableProfiler(
    profile_dataset=validator,
    excluded_expectations=None,
    ignored_columns=ignored_columns,
    not_null_only=False,
    primary_or_compound_key=['zone_id', 'start_of_period_utc'],
    semantic_types_dict=None,
    table_expectations_only=False,
    value_set_threshold="MANY",
)
suite = profiler.build_suite()
  1. get error message
File ~/.local/share/virtualenvs/surge_pricing-iSxDQiKA/lib/python3.10/site-packages/great_expectations/expectations/core/expect_column_values_to_be_of_type.py:576, in _get_dialect_type_module(execution_engine)
    571 # Bigquery works with newer versions, but use a patch if we had to define bigquery_types_tuple
    572 try:
    573     if (
    574         isinstance(
    575             execution_engine.dialect_module,
--> 576             sqla_bigquery.BigQueryDialect,
    577         )
    578         and bigquery_types_tuple is not None
    579     ):
    580         return bigquery_types_tuple
    581 except (TypeError, AttributeError):

NameError: name 'sqla_bigquery' is not defined

Expected behavior
I do not have the bigquery sqlalchemy dialect installed. This should just pass.

Environment (please complete the following information):

  • Operating System: MacOSX
  • Great Expectations Version: 0.14.7
@samLozier
Copy link

I also have this issue. same system config, I'm using snowflake.

@samLozier
Copy link

you could probably resolve it with a check:

"sqla_bigquery" in sys.modules

but it raises bigger questions about the test-suite matrix that probably need to be addressed.

@joshua-stauffer
Copy link
Member

hi @RoyalTS and @samLozier , thanks for raising this -- this is related to a bigquery update we pushed in last week's release, I have a PR in progress now to address.

@AFineDayFor AFineDayFor added bug Bugs bugs bugs! community labels Feb 22, 2022
@kenwade4
Copy link
Contributor

@RoyalTS and @samLozier We have mostly addressed this issue in a PR that was merged late last week #4249

There is another spot where this could come up that is addressed in #4273 (has not merged yet).

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity.

It will be closed if no further activity occurs. Thank you for your contributions 🙇

@github-actions github-actions bot added the stale Stale issues and PRs label Aug 5, 2022
@kenwade4 kenwade4 closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs bugs bugs! community stale Stale issues and PRs
Projects
None yet
Development

No branches or pull requests

5 participants