-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of waterway=pressurised #3180
Comments
https://taginfo.openstreetmap.org/tags/waterway=pressurised has 127 uses worldwide, it is too early to render it Please, open a new issue once usage is significant (#1630 has some discussion about what is "significant usage") but it is certainly counted in thousands (except extreme outliers like capital=yes). |
Hi I don't get how it can be more widely used if renders and editors make it bogus and unconsistent with other tags. There will surely be editing wars and misunderstandings if render doesn't match with wiki. Can you take this in your scope prior to wipe months of work please ? |
Note that renderers are not obligated to match the wiki, especially "proposed rendering" section. Any wiki page that has something like "renderers must...", "rendering of XYZ is obligatory", "XYZ must not be rendered" is wrong. If one spots page like this and for some reason is unwilling to fix it - please notify me at https://wiki.openstreetmap.org/w/index.php?title=User_talk:Mateusz_Konieczny&action=edit§ion=new or notify someone else about such mistake. |
For clarification: Historically absolute use numbers have not been considered a relevant criterion for deciding on use of a tag or not. If a tag is consistently used by a broader mapping community, has a verifiable meaning and rendering it in a certain way creates positive mapping incentive are the main factors. @gustavecha - the tags you proposed to consider in rendering are part of a new and highly complex tagging system. It would not be responsible to push and further interpret this system by rendering it here in a certain way before the global mapper basis had a chance to independently decide if an how to practically adopt the proposed tags and how to further develop their meaning. History has shown that waterway rendering is highly prone to influence mappers to tag for the renderer - see #2346 for a simple example. Adding further not well thought through stuff has the potential to do a lot of damage. |
2018-04-19 16:00 GMT+02:00 Gustave <[email protected]>:
I don't get how it can be more widely used if renders and editors make it
bogus and unconsistent with other tags.
Can you take this in your scope prior to wipe months of work please ?
it is generally a problem that most people only map things if they are
shown on the map (newbie and occasional users typically only map things
which have a preset).
In this case of a new waterway value, I agree with the team's decision to
wait for more usage.
|
|
It is certainly not a sole and only criterion but very low usage (say, below 1000 worldwide) usually indicates that tag has (currently) no broad support from community of mappers. To explain:
This is not a promise that tag will be rendered, just that at this moment waiting to see how this new tagging scheme is considered by OSM community is IMHO preferable rather than rushing to implement it. New tag used 50 times worldwide will (except really extreme cases) not be rendered in this style. New tag used 50 000 times worldwide may be rendered depending on other factors, most important ones mentioned by @imagico . |
Now used 2172 times on ways. Related to rendering |
I closed initially based on low usage count, so I will reopen. Note that is does not mean that it should or will be rendered, but that it does warrant review larger than "according to taginfo it is basically unused" |
Current usage: 1051 ways with 667 ways with 22 ways with 120 ways with 44 ways without The There are 1193 features which are underground pipelines or tunnels would need to be considered separately, since we probably will not render most underground pipelines. |
Thank you Joseph for those figures
This is pretty uncommon situations. The only possibility is to find a pipeline inside a human accessible tunnel, it exists only in a few places.
This sounds right : no pipeline but a pressurized tunnel
man_made=pipeline is required for usage=penstock, which can be a precious hint to fix them Ok with #640 As mentioned before, waterway + usage=headrace or waterway + usage=penstock have often great water flows. I'd be in favour they appear with a light blue line, eventually cased or dashed even underground. |
Would you be interested in making a PR to add this feature, along with
`man_made=pipeline`, once you are finished with the power=portal PR?
|
#4070 will add pipelines with location=overground, which will address some waterway=pressurised features |
Tests and demos in #4070 look very promising and are great for pipelines |
@flacombe: what about the rendering of |
Hi @jragusa Just to be sure, is tunnel=flooded that is rendered or the combination waterway=canal + tunnel=flooded? However I completely second what is proposed in #3354 All the best |
Currently, only |
Well, it would be great to extend it to waterway=pressurised. pressurised or canal don't inform us on tunnel size. While this canal is 1.5m wide |
Only one of those three ways includes a width= or diameter= tag.
How do you know the size? Is this information in an external public data
set?
|
First of all it's possible to measure ones with open air outlets, at downside outlet. First pressurised tunnel corresponds to this map showing internal diameters (i missed to add diameter on osm object). Last one was measured directly on outlet (and missed to add it as well) |
There are now 176 waterway=pressurized with tunnel=* but without pipeline=* according to http://overpass-turbo.eu/s/TmH - Many are 5 to 20 km long hydroelectric features which cut across the topography. I'm not sure if these should be rendered on a general-purpose map: |
It's up to maintainers, depending on what they want. These ones are really large ones, water flows at 30m3/s or more inside. |
Please have a look at https://www.openstreetmap.org/way/741661665 , a waterway=pressurised+usage=penstock of Kraftwerksgruppe_Kaprun I think rendering penstocks in high zoom levels in Carto would be a good for understanding the hydro system of hydropower plants which are supplied by underground water canals and pressurized pipelines. Meanwhile artificial hydropower-waterways are well documented: https://wiki.openstreetmap.org/wiki/Tag:usage%3Dheadrace and https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dpressurised For example how penstocks and headrace are rendered in Austrians national map by dashed blue lines: |
Hello @SonnyLidarDTM IMHO, waterway=pressurised should be rendered as any waterway (we yet have to find exactly how). Penstocks, headraces are very specific and I'm not sure they should be distinguised from any other pressurised waterway on carto render. I've made out some particular render for such: https://map.infos-reseaux.com/#10.55/45.2372/6.4844/H,L The question will got even different answer for topographic maps as the one you mention on bev.gv.at (or opentopomap). It's good to see some interest on the topic anyway, thank you. |
Updated use numbers:
|
I don't really understand what is being proposed in terms of rendering. Most I think the decision not to render underground features is right, otherwise the map will be cluttered by invisible infrastructure. There are dedicated infrastructure maps that will always do a much better job of showing the connectivity. |
sent from a phone
On 18 Jan 2025, at 11:05, dch0ph ***@***.***> wrote:
I think the decision not to render underground features is right, otherwise the map will be cluttered by invisible infrastructure.
we actually do render underground features, nearly all tunnel=yes/culvert features are underground.
|
I think i can clear this up: We do not universally refrain from rendering underground features but we are naturally very careful rendering large underground structures not publicly accessible because these are - where mapped - not based on verifiable local knowledge but tend to be derived from non-verifiable third party sources. Tagging in OSM does not universally distinguish these from stuff that can be verifiably mapped from local knowledge - hence we in some cases interpret dual use tagging (like For underground pipelines (and possibly similar water carrying structures - even if they are not tagged as Addressing this issue should therefore focus on rendering structures visible at the surface. This clearly relates to existing rendering of Also please consider that we have a substantial backlog of issues related to the existing rendering of waterways (like #2346, #3354, #3676, #3795, #4267). |
Expected behavior
Render waterway=pressurised [eventually filter with specific usage=, tunnel= or location=* values] as a thin blue line cased in strong grey [or any colour suitable for render consistence] solid lines.
Use casing dashes for tunnels
Waterway=pressurised is a new value to map features where water flows under pressure (which weren't mapped so far)
https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dpressurised
Actual behavior
No rendering of any waterway=pressurised
Links and screenshots illustrating the problem
https://www.openstreetmap.org/way/243333033 (overground penstock)
https://www.openstreetmap.org/way/243333009 (underground tunnel)
The text was updated successfully, but these errors were encountered: