Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsh Profile read/write consolidation and tests #6233

Closed
Joerger opened this issue Mar 30, 2021 · 1 comment
Closed

tsh Profile read/write consolidation and tests #6233

Joerger opened this issue Mar 30, 2021 · 1 comment
Assignees
@Joerger

Comments

@Joerger
Copy link
Contributor

Joerger commented Mar 30, 2021 •
edited
Loading

tsh Profile read/write logic is currently disjointed. When tsh Profile paths are updated, there are multiple places in the code that need to be updated, and errors can potentially slip through without any tests alerting it. For example - #6214

Profile read/write logic should use the same helper functions and ideally be in the same package/file, which will assist in writing tests.
@Joerger Joerger self-assigned this Mar 30, 2021
@Joerger Joerger mentioned this issue Mar 30, 2021
Merged
@Joerger Joerger mentioned this issue Apr 9, 2021
Closed
7 tasks
@Joerger
Copy link
Contributor Author

Joerger commented Apr 14, 2021

Closing since this will be handled in #6393

@Joerger Joerger closed this as completed Apr 14, 2021
@Joerger Joerger mentioned this issue May 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joerger Joerger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Joerger