Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop session clipboard and directory sharing icon state is unclear #36825

Closed
ibeckermayer opened this issue Jan 17, 2024 · 5 comments · Fixed by #36908
Closed

Desktop session clipboard and directory sharing icon state is unclear #36825

ibeckermayer opened this issue Jan 17, 2024 · 5 comments · Fixed by #36908
Labels
bug desktop-access test-plan-problem Issues which have been surfaced by running the manual release test plan ui

Comments

@ibeckermayer
Copy link
Contributor

ibeckermayer commented Jan 17, 2024

I'm unable to visually determine whether clipboard sharing / directory sharing is active during a desktop session by looking at the icons. They're supposed to be "grayed out" (or otherwise disabled-looking) when inactive, and more bold when active. However here is what inactive looks like:

both directory and clipboard sharing disabled by rbac (and inactive):

image

clipboard enabled by rbac, but disabled by browser permissions

image

both enabled:

image
@ibeckermayer ibeckermayer added bug test-plan-problem Issues which have been surfaced by running the manual release test plan ui desktop-access labels Jan 17, 2024
@zmb3
Copy link
Collaborator

zmb3 commented Jan 18, 2024

Maybe we could use the same accent color that the new toggle components use to indicate an active state.

WDYT, @roraback?

@roraback
Copy link
Contributor

I’m thinking that we should do the following:

  • If disabled, we should use the disabled color, rather than the “slightly muted” color (what they currently are using)
  • If enabled, either make them green OR make them more opaque black with a green dot overlaid in the UR corner
  • Add a tooltip on hover, rather than relying on a title attribute—title attributes are less reliable and can require hovering for an extended amount of time before the title appears

An additional note: it looks like the alerts button next to these icons is has a hard-coded white. I'm seeing a white icon and white text regardless of whether I'm in light or dark mode:
image
image

@roraback
Copy link
Contributor

Since the icons aren't interactive even when they're active, the data version of our green color is probably most appropriate (but FWIW it is identical to the "interactive/success/default" color in our design system).

@ibeckermayer
Copy link
Contributor Author

@roraback iirc we used to have it green but moved away from that because it was a bit jarring. I'm not too partial on that, but this was the simplest change and works fine to my eye. WDYT?

Disabled:
image
image

Enabled:
image
image

@zmb3
Copy link
Collaborator

zmb3 commented Jan 19, 2024

@ibeckermayer let's stick to Kenny's suggestions please. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug desktop-access test-plan-problem Issues which have been surfaced by running the manual release test plan ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants