-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop session clipboard and directory sharing icon state is unclear #36825
Comments
Maybe we could use the same accent color that the new toggle components use to indicate an active state. WDYT, @roraback? |
Since the icons aren't interactive even when they're active, the data version of our green color is probably most appropriate (but FWIW it is identical to the "interactive/success/default" color in our design system). |
@roraback iirc we used to have it green but moved away from that because it was a bit jarring. I'm not too partial on that, but this was the simplest change and works fine to my eye. WDYT? |
@ibeckermayer let's stick to Kenny's suggestions please. 🙏 |
I'm unable to visually determine whether clipboard sharing / directory sharing is active during a desktop session by looking at the icons. They're supposed to be "grayed out" (or otherwise disabled-looking) when inactive, and more bold when active. However here is what inactive looks like:
both directory and clipboard sharing disabled by rbac (and inactive):
clipboard enabled by rbac, but disabled by browser permissions
both enabled:
The text was updated successfully, but these errors were encountered: